Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pipeline launch page #2015

Open
Tracked by #2429
ewels opened this issue Oct 5, 2023 · 8 comments
Open
Tracked by #2429

Rewrite pipeline launch page #2015

ewels opened this issue Oct 5, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@ewels
Copy link
Member

ewels commented Oct 5, 2023

The pipeline launch page is one of the few that didn't make it into the new Astro rebuild. At the time of writing, that's still running at oldsite.nf-co.re with source code lurking on the old-site branch here. We do some redirection magic to make that new website render the URL from the oldsite without anyone knowing 🤫

We need to rewrite the nf-core web launch pages. I've previously discussed this with @mashehu but I forget the details now, so intention is to come back later and edit this issue to include more detail.

@ewels ewels added the enhancement New feature or request label Oct 5, 2023
@multimeric
Copy link

Can you explain the technologies that might be used to rewrite the launch page? Because as I understand it can't all be done client side.

I might be able to help with this, assuming that the launch service can be modularised to run separately from the rest of the site, since I'm interested in hosting my own copy of the launch service only. For example if it were hosted on AWS I'd be happy to work on a lambda function that handles the backend logic, and a Svelte component for the frontend.

@mashehu
Copy link
Contributor

mashehu commented Jan 29, 2024

nothing written in stone yet. but we would like to launch a a local server from the CLI (so people can use it in offline environments and also we don't send sensitive data around) and then reuse our tech-stack (astro+svelte) for the launcher pages (my current gut feeling is to use something like https://vite-pwa-org.netlify.app/ to do that, but haven't looked to much into it.) you are very welcome to contribute to it (I will hopefully start this endeavor this or next week.

@multimeric
Copy link

Okay that sounds great. If the web app can run locally that resolves my issue and makes it even more useful for me to contribute the feature. Can you explain why you want to re-use the tech stack if the CLI is a separate repo to the website? Is it to maintain a consistent style?

Please let me know when the tech decisions have progressed enough for me to make a start on this, because I happen to have some available time for this now. Otherwise I can also wait for your implementation later on.

@mashehu
Copy link
Contributor

mashehu commented Jan 29, 2024

yep, style consistency is one of the main reason for sticking with the current stack. Additionally, we will can hopefully reuse components from/for other pages (parameters page, schema builder page)

@ewels
Copy link
Member Author

ewels commented Feb 4, 2024

NB: The schema builder page will also run from the CLI, with a local server. So that and the rewritten launch will both be in nf-core/tools I guess.

@multimeric
Copy link

multimeric commented Feb 4, 2024

Good point. Should I open another issue in that repo?

@mashehu
Copy link
Contributor

mashehu commented Feb 5, 2024

no need, thanks, we are already trying to gather everything there: nf-core/tools#2429

@multimeric
Copy link

That task seems to be about supporting the nextflow schema, rather than the launch page? Is nf-core/tools#2463 maybe more relevant? I would love to progress this if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants