Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] arc update does not transfer all info from isa.assay (v1-pre2) #229

Open
Brilator opened this issue Nov 20, 2023 · 3 comments
Open
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@Brilator
Copy link
Member

Describe the bug

arc update does not transfer all info from isa.assay.
Sections STUDY PROTOCOLS and STUDY CONTACTS are not updated.

Version: https://github.com/nfdi4plants/ARCCommander/releases/download/v1.0.0-preview.2/arc_osx-x64

To Reproduce

  1. add some metadata info by hand
open ./assays/v1pre2-Assay/isa.assay.xlsx
  1. update
arc_osx-x64 update
  1. check
open isa.investigation.xlsx
@HLWeil
Copy link
Member

HLWeil commented Nov 20, 2023

  • Keeping the persons in the assay and not copy them to the study is by design, see [BUG] ASSAY PERFORMERS added as STUDY CONTACTS to isa.investigation.xlsx #216
  • The protocols is more of a technical thing, as it's kind of a mess to keep all these places in the specification with similar information updated against each other but still separated. If the information from the assay is migrated into the study, you can't really distinguish where it came from (similar to persons)

@HLWeil
Copy link
Member

HLWeil commented Nov 20, 2023

What the arc update mostly does now is updating the Input and Outputs, so that all these Source Name inputs that actually are samples or data files are now correctly saved as Input [Sample Name] and so on..

@andreaschrader
Copy link
Member

We experienced something similar when providing ASSAY INFORMATION and ASSAY PERFORMERS in the isa.assay file, nothing was updated in the isa.investigation file upon 'arc update'.

I would expect the isa.investigation file to capture all information.
I would expect information from ASSAY INFORMATION to be updated in the isa.investigation file and ASSAY PERFORMERS to be listed there as ASSAY PERFORMERS for the respective assay.

@omaus omaus added the Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
Status: No status
Development

No branches or pull requests

4 participants