Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ARCtrl and some additional dependencies #4

Closed
kMutagene opened this issue Jul 17, 2024 · 4 comments · Fixed by #5
Closed

Update ARCtrl and some additional dependencies #4

kMutagene opened this issue Jul 17, 2024 · 4 comments · Fixed by #5
Assignees

Comments

@kMutagene
Copy link
Member

No description provided.

@kMutagene
Copy link
Member Author

@HLWeil what do you think how robust such an update will be? this tool is used on every commit on every arc on the datahub.

@kMutagene kMutagene self-assigned this Jul 25, 2024
@kMutagene kMutagene moved this to Backlog in ARCStack Jul 25, 2024
@HLWeil
Copy link
Member

HLWeil commented Jul 26, 2024

As the current ARCtrl version is used in ARCitect, I would expect the read-in to be fairly robust.

But there might be Issues with very old ARCs
nfdi4plants/ARCCommander#240

@kMutagene
Copy link
Member Author

i am mostly concerned with the json output. Ideally, we can use this update occasion to switch the output to RO crate.

So will

All ARCs -> Read -> RO Crate Json

Work? i mean we can and will still put empty json there on error, just asking how ready things are here

@kMutagene kMutagene moved this from Backlog to In progress in ARCStack Jul 30, 2024
@HLWeil
Copy link
Member

HLWeil commented Jul 30, 2024

We could also allow both ISA and RO-Crate json via CLI args.

For RO-Crate I would first implement nfdi4plants/ARCtrl#344, and then use that function here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants