Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme:layout-default): add fetching property #1614

Merged
merged 3 commits into from
Jul 20, 2023
Merged

feat(theme:layout-default): add fetching property #1614

merged 3 commits into from
Jul 20, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jul 19, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jul 19, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1614 (79670d1) into master (45863a1) will decrease coverage by 0.02%.
The diff coverage is 77.77%.

❗ Current head 79670d1 differs from pull request most recent head 6dfbc52. Consider uploading reports for the commit 6dfbc52 to get more accurate results

@@            Coverage Diff             @@
##           master    #1614      +/-   ##
==========================================
- Coverage   95.51%   95.49%   -0.02%     
==========================================
  Files         277      277              
  Lines        8525     8532       +7     
  Branches     1668     1669       +1     
==========================================
+ Hits         8143     8148       +5     
- Misses        317      319       +2     
  Partials       65       65
Impacted Files Coverage Δ
packages/theme/layout-default/layout.component.ts 85.96% <77.77%> (-2.04%) ⬇️

@cipchk cipchk merged commit 8446da6 into master Jul 20, 2023
8 checks passed
@cipchk cipchk deleted the issues-2403 branch July 20, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[layout] Support control top progressbar
2 participants
@cipchk @ng-alain-bot