Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth:cookie): fix cookie expires #1636

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix(auth:cookie): fix cookie expires #1636

merged 2 commits into from
Aug 2, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Aug 2, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1636 (00f441a) into master (810ba02) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 00f441a differs from pull request most recent head e8e0a13. Consider uploading reports for the commit e8e0a13 to get more accurate results

@@           Coverage Diff           @@
##           master    #1636   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files         277      277           
  Lines        8560     8561    +1     
  Branches     1681     1682    +1     
=======================================
+ Hits         8176     8177    +1     
  Misses        319      319           
  Partials       65       65
Files Changed Coverage Δ
packages/auth/src/store/cookie-storage.service.ts 100.00% <100.00%> (ø)

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Aug 2, 2023 •
edited
Loading

Preview is ready!

@cipchk cipchk merged commit eca7bcb into master Aug 2, 2023
8 checks passed
@cipchk cipchk deleted the issues-auth-store-cookie branch August 2, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipchk @ng-alain-bot