From 16c0db8d880b491b4b832afc9b8ac354094084d5 Mon Sep 17 00:00:00 2001
From: cipchk <cipchk@qq.com>
Date: Fri, 4 Aug 2023 16:29:13 +0800
Subject: [PATCH 1/3] refactor(abc:st): use `Observable` instead of `Promise`
 of load

- close https://github.com/ng-alain/ng-alain/issues/2233
---
 packages/abc/st/st-data-source.ts      |   6 +-
 packages/abc/st/st-td.component.html   |   2 +-
 packages/abc/st/st.component.ts        | 167 +++++++++++--------------
 packages/abc/st/test/base.spec.ts      |   6 +-
 packages/abc/st/test/st-filter.spec.ts |   3 +-
 packages/abc/st/test/st.spec.ts        |  46 +++----
 6 files changed, 101 insertions(+), 129 deletions(-)

diff --git a/packages/abc/st/st-data-source.ts b/packages/abc/st/st-data-source.ts
index cc9a5afb0..51080aa7c 100644
--- a/packages/abc/st/st-data-source.ts
+++ b/packages/abc/st/st-data-source.ts
@@ -40,7 +40,7 @@ export interface STDataSourceOptions {
   pi: number;
   ps: number;
   paginator: boolean;
-  data: string | STData[] | Observable<STData[]>;
+  data?: string | STData[] | Observable<STData[]>;
   total: number;
   req: STReq;
   res: STRes;
@@ -127,8 +127,8 @@ export class STDataSource {
           return deepCopy(ret);
         })
       );
-    } else if (Array.isArray(data)) {
-      data$ = of(data);
+    } else if (data == null || Array.isArray(data)) {
+      data$ = of(data ?? []);
     } else {
       // a cold observable
       data$ = data;
diff --git a/packages/abc/st/st-td.component.html b/packages/abc/st/st-td.component.html
index fd2d98af1..18d43d670 100644
--- a/packages/abc/st/st-td.component.html
+++ b/packages/abc/st/st-td.component.html
@@ -45,7 +45,7 @@
   #render
   [ngTemplateOutlet]="c.__render!"
   [ngTemplateOutletContext]="{ $implicit: i, index: index, column: c }"
-></ng-template>
+/>
 <ng-container *ngIf="!c.__render; else render">
   <ng-container [ngSwitch]="c.type">
     <label
diff --git a/packages/abc/st/st.component.ts b/packages/abc/st/st.component.ts
index 9d770054d..edbc686f2 100644
--- a/packages/abc/st/st.component.ts
+++ b/packages/abc/st/st.component.ts
@@ -13,7 +13,6 @@ import {
   Inject,
   Input,
   OnChanges,
-  OnDestroy,
   Optional,
   Output,
   SimpleChange,
@@ -25,7 +24,7 @@ import {
 } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { Router } from '@angular/router';
-import { from, isObservable, Observable, of, Subscription, filter } from 'rxjs';
+import { from, isObservable, Observable, of, filter, catchError, map, finalize, throwError } from 'rxjs';
 
 import {
   AlainI18NService,
@@ -97,7 +96,7 @@ import { _STColumn, _STDataValue, _STHeader, _STTdNotify, _STTdNotifyType } from
   changeDetection: ChangeDetectionStrategy.OnPush,
   encapsulation: ViewEncapsulation.None
 })
-export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
+export class STComponent implements AfterViewInit, OnChanges {
   static ngAcceptInputType_ps: NumberInput;
   static ngAcceptInputType_pi: NumberInput;
   static ngAcceptInputType_total: NumberInput;
@@ -113,8 +112,6 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
   static ngAcceptInputType_virtualMinBufferPx: NumberInput;
 
   private destroy$ = inject(DestroyRef);
-  private isDestroy = false;
-  private data$?: Subscription;
   private totalTpl = ``;
   cog!: AlainSTConfig;
   private _req!: STReq;
@@ -134,7 +131,7 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
   _headers: _STHeader[][] = [];
   _columns: _STColumn[] = [];
   contextmenuList: STContextmenuItem[] = [];
-  @ViewChild('table') readonly orgTable!: NzTableComponent<STData>;
+  @ViewChild('table') readonly orgTable?: NzTableComponent<STData>;
   @ViewChild('contextmenuTpl') readonly contextmenuTpl!: NzDropdownMenuComponent;
 
   @Input()
@@ -166,7 +163,7 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
     this._page = { ...this.cog.page, ...value };
     this.updateTotalTpl();
   }
-  @Input() data!: string | STData[] | Observable<STData[]>;
+  @Input() data?: string | STData[] | Observable<STData[]>;
   @Input() columns?: STColumn[] | null;
   @Input() contextmenu?: STContextmenuFn | null;
   @Input() @InputNumber() ps = 10;
@@ -333,8 +330,8 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
    * - 本地数据：包含排序、过滤后不分页数据
    * - 远程数据：不传递 `pi`、`ps` 两个参数
    */
-  get filteredData(): Promise<STData[]> {
-    return this.loadData({ paginator: false } as NzSafeAny).then(res => res.list);
+  get filteredData(): Observable<STData[]> {
+    return this.loadData({ paginator: false } as unknown as STDataSourceOptions).pipe(map(res => res.list));
   }
 
   private updateTotalTpl(): void {
@@ -355,78 +352,62 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
     }
   }
 
-  private loadData(options?: STDataSourceOptions): Promise<STDataSourceResult> {
+  private loadData(options?: STDataSourceOptions): Observable<STDataSourceResult> {
     const { pi, ps, data, req, res, page, total, singleSort, multiSort, rowClassName } = this;
-    return new Promise((resolvePromise, rejectPromise) => {
-      if (this.data$) {
-        this.data$.unsubscribe();
-      }
-
-      this.data$ = this.dataSource
-        .process({
-          pi,
-          ps,
-          total,
-          data,
-          req,
-          res,
-          page,
-          columns: this._columns,
-          singleSort,
-          multiSort,
-          rowClassName,
-          paginator: true,
-          customRequest: this.customRequest || this.cog.customRequest,
-          ...options
-        })
-        .pipe(takeUntilDestroyed(this.destroy$))
-        .subscribe({
-          next: result => resolvePromise(result),
-          error: error => {
-            if (typeof ngDevMode === 'undefined' || ngDevMode) {
-              console.warn('st.loadDate', error);
-            }
-            rejectPromise(error);
-          }
-        });
-    });
+    return this.dataSource
+      .process({
+        pi,
+        ps,
+        total,
+        data,
+        req,
+        res,
+        page,
+        columns: this._columns,
+        singleSort,
+        multiSort,
+        rowClassName,
+        paginator: true,
+        customRequest: this.customRequest || this.cog.customRequest,
+        ...options
+      })
+      .pipe(takeUntilDestroyed(this.destroy$));
   }
 
-  private async loadPageData(): Promise<this> {
+  private loadPageData(): Observable<this> {
     this.setLoading(true);
-    try {
-      const result = await this.loadData();
-      this.setLoading(false);
-      const undefinedString = 'undefined';
-      if (typeof result.pi !== undefinedString) {
-        this.pi = result.pi;
-      }
-      if (typeof result.ps !== undefinedString) {
-        this.ps = result.ps;
-      }
-      if (typeof result.total !== undefinedString) {
-        this.total = result.total;
-      }
-      if (typeof result.pageShow !== undefinedString) {
-        this._isPagination = result.pageShow;
-      }
-      this._data = result.list;
-      this._statistical = result.statistical as STStatisticalResults;
-      this.changeEmit('loaded', result.list);
-      // Should be re-render in next tike when using virtual scroll
-      // https://github.com/ng-alain/ng-alain/issues/1836
-      if (this.cdkVirtualScrollViewport) {
-        Promise.resolve().then(() => this.cdkVirtualScrollViewport.checkViewportSize());
-      }
-      return this._refCheck();
-    } catch (error) {
-      this.setLoading(false);
-      if (!this.isDestroy) {
-        this.cdr.detectChanges();
+    return this.loadData().pipe(
+      finalize(() => this.setLoading(false)),
+      catchError(error => {
         this.error.emit({ type: 'req', error });
-      }
-      return this;
-    }
+        return throwError(() => error);
+      }),
+      map(result => {
+        const undefinedString = 'undefined';
+        if (typeof result.pi !== undefinedString) {
+          this.pi = result.pi;
+        }
+        if (typeof result.ps !== undefinedString) {
+          this.ps = result.ps;
+        }
+        if (typeof result.total !== undefinedString) {
+          this.total = result.total;
+        }
+        if (typeof result.pageShow !== undefinedString) {
+          this._isPagination = result.pageShow;
+        }
+        this._data = result.list ?? [];
+        this._statistical = result.statistical as STStatisticalResults;
+        this.changeEmit('loaded', result.list);
+        // Should be re-render in next tike when using virtual scroll
+        // https://github.com/ng-alain/ng-alain/issues/1836
+        if (this.cdkVirtualScrollViewport != null) {
+          Promise.resolve().then(() => this.cdkVirtualScrollViewport?.checkViewportSize());
+        }
+        this._refCheck();
+        return this;
+      })
+    );
   }
 
   /** 清空所有数据 */
@@ -502,7 +483,7 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
 
   _change(type: 'pi' | 'ps', options?: STLoadOptions): void {
     if (type === 'pi' || (type === 'ps' && this.pi <= Math.ceil(this.total / this.ps))) {
-      this.loadPageData().then(() => this._toTop(options?.toTop));
+      this.loadPageData().subscribe(() => this._toTop(options?.toTop));
     }
 
     this.changeEmit(type);
@@ -663,13 +644,14 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
       this._columns.forEach((item, index) => (item._sort.default = index === idx ? value : null));
     }
     this.cdr.detectChanges();
-    this.loadPageData();
-    const res = {
-      value,
-      map: this.dataSource.getReqSortMap(this.singleSort, this.multiSort, this._columns),
-      column: col
-    };
-    this.changeEmit('sort', res);
+    this.loadPageData().subscribe(() => {
+      const res = {
+        value,
+        map: this.dataSource.getReqSortMap(this.singleSort, this.multiSort, this._columns),
+        column: col
+      };
+      this.changeEmit('sort', res);
+    });
   }
 
   clearSort(): this {
@@ -688,8 +670,7 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
     // 过滤表示一种数据的变化应重置页码为 `1`
     this.pi = 1;
     this.columnSource.updateDefault(col.filter!);
-    this.loadPageData();
-    this.changeEmit('filter', col);
+    this.loadPageData().subscribe(() => this.changeEmit('filter', col));
   }
 
   handleFilterNotify(value?: unknown): void {
@@ -833,11 +814,11 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
   }
   // #endregion
 
-  get cdkVirtualScrollViewport(): CdkVirtualScrollViewport {
-    return this.orgTable.cdkVirtualScrollViewport!;
+  get cdkVirtualScrollViewport(): CdkVirtualScrollViewport | undefined {
+    return this.orgTable?.cdkVirtualScrollViewport;
   }
 
-  resetColumns(options?: STResetColumnsOption): Promise<this> {
+  resetColumns(options?: STResetColumnsOption): Observable<this> {
     options = { emitReload: true, preClearData: false, ...options };
     if (typeof options.columns !== 'undefined') {
       this.columns = options.columns;
@@ -860,7 +841,7 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
       return this.loadPageData();
     } else {
       this.cd();
-      return Promise.resolve(this);
+      return of(this);
     }
   }
 
@@ -914,16 +895,12 @@ export class STComponent implements AfterViewInit, OnChanges, OnDestroy {
     }
     const changeData = changes.data;
     if (changeData && changeData.currentValue && !(this.req.lazyLoad && changeData.firstChange)) {
-      this.loadPageData();
+      this.loadPageData().subscribe();
     }
     if (changes.loading) {
       this._loading = changes.loading.currentValue;
     }
   }
-
-  ngOnDestroy(): void {
-    this.isDestroy = true;
-  }
 }
 
 @Component({
diff --git a/packages/abc/st/test/base.spec.ts b/packages/abc/st/test/base.spec.ts
index b43d9770d..c202db74e 100644
--- a/packages/abc/st/test/base.spec.ts
+++ b/packages/abc/st/test/base.spec.ts
@@ -27,6 +27,7 @@ import {
   STColumnTitle,
   STContextmenuFn,
   STCustomRequestOptions,
+  STError,
   STMultiSort,
   STPage,
   STReq,
@@ -138,6 +139,7 @@ export class PageObject<T extends TestComponent> {
   readonly comp: STComponent;
   readonly i18nSrv: AlainI18NService;
   readonly registerWidget: STWidgetRegistry;
+  spyErrorData?: STError;
 
   constructor(minColumn: boolean = false, type: Type<T>) {
     this.registerWidget = TestBed.inject(STWidgetRegistry);
@@ -153,7 +155,7 @@ export class PageObject<T extends TestComponent> {
       this.context.columns = [{ title: '', index: 'id' }];
     }
 
-    spyOn(this.context as NzSafeAny, 'error');
+    spyOn(this.context as NzSafeAny, 'error').and.callFake((res: STError) => (this.spyErrorData = res));
     this.changeSpy = spyOn(this.context as NzSafeAny, 'change').and.callFake(
       ((e: NzSafeAny) => (this._changeData = e)) as NzSafeAny
     );
@@ -419,7 +421,7 @@ export class PageObject<T extends TestComponent> {
       [contextmenu]="contextmenu"
       [customRequest]="customRequest"
       (change)="change($event)"
-      (error)="error()"
+      (error)="error($event)"
     />
     <ng-template #tpl let-handle="handle">
       <span>In tpl</span>
diff --git a/packages/abc/st/test/st-filter.spec.ts b/packages/abc/st/test/st-filter.spec.ts
index cf7ff41b7..82361db22 100644
--- a/packages/abc/st/test/st-filter.spec.ts
+++ b/packages/abc/st/test/st-filter.spec.ts
@@ -114,10 +114,9 @@ describe('abc: st-filter', () => {
       filter = firstCol.filter!;
     });
     it('should be filter', () => {
-      expect(context.change).not.toHaveBeenCalled();
       const filterComp = dl.query(By.directive(STFilterComponent)).context as STFilterComponent;
       filterComp.confirm();
-      expect(context.change).toHaveBeenCalled();
+      expect(page._changeData?.type).toBe('filter');
     });
     it('should be clean', () => {
       const m = filter.menus![0];
diff --git a/packages/abc/st/test/st.spec.ts b/packages/abc/st/test/st.spec.ts
index 298193fe0..561347152 100644
--- a/packages/abc/st/test/st.spec.ts
+++ b/packages/abc/st/test/st.spec.ts
@@ -826,24 +826,12 @@ describe('abc: st', () => {
         });
       });
       describe('Http Request', () => {
-        it('when error request', done => {
+        it('when error request', () => {
           spyOn(_http, 'request').and.returnValue(throwError(() => 'cancel'));
           context.data = '/mock';
           fixture.detectChanges();
-          fixture.whenStable().then(() => {
-            expect(comp._data.length).toBe(0);
-            done();
-          });
-        });
-        it('should be ingore catch error when component is destroyed', done => {
-          expect(context.error).not.toHaveBeenCalled();
-          context.data = '/mock';
-          fixture.detectChanges();
-          comp.ngOnDestroy();
-          fixture.whenStable().then(() => {
-            expect(context.error).not.toHaveBeenCalled();
-            done();
-          });
+          expect(page.spyErrorData?.error).toBe('cancel');
+          TestBed.resetTestingModule();
         });
         it('should be ingored incomplete request when has new request', fakeAsync(() => {
           let mockData = [{}];
@@ -860,7 +848,7 @@ describe('abc: st', () => {
           expect(comp._data.length).toBe(mockData.length);
         }));
         it('#customRequest', fakeAsync(() => {
-          context.customRequest = jasmine.createSpy('customRequest');
+          context.customRequest = jasmine.createSpy('customRequest').and.callFake(() => of([]));
           context.data = '/invalid-url';
           fixture.detectChanges();
           tick(1000);
@@ -922,7 +910,7 @@ describe('abc: st', () => {
         let load = 0;
         spyOn(context.comp as any, 'loadData').and.callFake(() => {
           ++load;
-          return Promise.resolve({});
+          return of({});
         });
         const pc = dl
           .query(By.directive(NzPaginationComponent))
@@ -1054,9 +1042,9 @@ describe('abc: st', () => {
         context.scroll = { x: '100px', y: '100px' };
         page.cd();
         expect(context.comp.cdkVirtualScrollViewport != null).toBe(true);
-        spyOn(context.comp.cdkVirtualScrollViewport, 'checkViewportSize');
+        spyOn(context.comp.cdkVirtualScrollViewport!!, 'checkViewportSize');
         page.cd().go(2);
-        expect(context.comp.cdkVirtualScrollViewport.checkViewportSize).toHaveBeenCalled();
+        expect(context.comp.cdkVirtualScrollViewport!!.checkViewportSize).toHaveBeenCalled();
         page.asyncEnd();
       }));
       it('should be working in only x is set', fakeAsync(() => {
@@ -1390,14 +1378,16 @@ describe('abc: st', () => {
           const cls = '.st__body tr[data-index="0"] td';
           page.updateColumn([{ title: '', index: 'name' }]).expectElCount(cls, 1);
           comp.resetColumns({ preClearData: true, columns: [{ title: '', index: 'invalid-name' }] });
-          page.cd().expectElContent(cls, '').asyncEnd();
+          page.cd();
+          expect(page.comp._data.length).toBe(0);
+          expect(page.get('nz-embed-empty') != null).toBe(true);
         }));
       });
       it('#filteredData', fakeAsync(() => {
         page.cd();
         expect((comp.data as any[]).length).toBe(DEFAULTCOUNT);
         expect(comp._data.length).toBe(PS);
-        comp.filteredData.then(list => {
+        comp.filteredData.subscribe(list => {
           expect(list.length).toBe(DEFAULTCOUNT);
         });
         page.asyncEnd();
@@ -1451,7 +1441,7 @@ describe('abc: st', () => {
         it('when data is true', fakeAsync(() => {
           context.data = genData(1);
           page.cd();
-          spyOnProperty(comp, 'filteredData', 'get').and.returnValue(Promise.resolve([]));
+          spyOnProperty(comp, 'filteredData', 'get').and.returnValue(of([]));
           expect(exportSrv.export).not.toHaveBeenCalled();
           comp.export(true);
           page.cd();
@@ -1511,8 +1501,7 @@ describe('abc: st', () => {
         context.loading = true;
         page.cd().expectElCount(`.ant-spin-spinning`, 1);
         context.loading = false;
-        page.cd();
-        page.expectElCount(`.ant-spin-spinning`, 0).asyncEnd();
+        page.cd().expectElCount(`.ant-spin-spinning`, 0).asyncEnd();
       }));
     });
     describe('#button', () => {
@@ -1628,8 +1617,13 @@ describe('abc: st', () => {
             <ng-template st-row="id" let-item><div class="j-id">id{{item.id}}</div></ng-template>
           </st>`
       })!;
-      page.updateColumn([{ title: '', index: 'id', render: 'id' }]);
-      expect(page.getCell().querySelector('.j-id')!.textContent).toBe('id1');
+      page.cd();
+      page.updateColumn([{ title: '', render: 'id' }]).cd();
+      const jIdEl = page.getCell().querySelector('.j-id');
+      expect(jIdEl != null)
+        .withContext('expect found j-id')
+        .toBe(true);
+      expect(jIdEl?.textContent).toBe('id1');
       page.asyncEnd();
     }));
     it('allow invalid id', fakeAsync(() => {

From 3ccc474ec47024512dc9a74a6990dff9face4652 Mon Sep 17 00:00:00 2001
From: cipchk <cipchk@qq.com>
Date: Fri, 4 Aug 2023 16:54:58 +0800
Subject: [PATCH 2/3] chore: fix

---
 packages/abc/st/demo/virtual.md |  4 ++--
 packages/abc/st/st.component.ts | 12 ++++++++----
 packages/abc/st/test/st.spec.ts |  5 +----
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/packages/abc/st/demo/virtual.md b/packages/abc/st/demo/virtual.md
index b1b9dceda..54aa7639e 100644
--- a/packages/abc/st/demo/virtual.md
+++ b/packages/abc/st/demo/virtual.md
@@ -55,11 +55,11 @@ export class DemoComponent implements AfterViewInit {
   ];
 
   scrollToIndex(index: number): void {
-    this.st.cdkVirtualScrollViewport.scrollToIndex(index);
+    this.st.cdkVirtualScrollViewport?.scrollToIndex(index);
   }
 
   ngAfterViewInit(): void {
-    this.st.cdkVirtualScrollViewport.scrolledIndexChange.pipe(takeUntilDestroyed(this.destroy$)).subscribe(data => {
+    this.st.cdkVirtualScrollViewport?.scrolledIndexChange.pipe(takeUntilDestroyed(this.destroy$)).subscribe(data => {
       console.log('scroll index to', data);
     });
   }
diff --git a/packages/abc/st/st.component.ts b/packages/abc/st/st.component.ts
index edbc686f2..790006d50 100644
--- a/packages/abc/st/st.component.ts
+++ b/packages/abc/st/st.component.ts
@@ -24,7 +24,7 @@ import {
 } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { Router } from '@angular/router';
-import { from, isObservable, Observable, of, filter, catchError, map, finalize, throwError } from 'rxjs';
+import { isObservable, Observable, of, filter, catchError, map, finalize, throwError, lastValueFrom } from 'rxjs';
 
 import {
   AlainI18NService,
@@ -131,7 +131,7 @@ export class STComponent implements AfterViewInit, OnChanges {
   _headers: _STHeader[][] = [];
   _columns: _STColumn[] = [];
   contextmenuList: STContextmenuItem[] = [];
-  @ViewChild('table') readonly orgTable?: NzTableComponent<STData>;
+  @ViewChild('table') readonly orgTable!: NzTableComponent<STData>;
   @ViewChild('contextmenuTpl') readonly contextmenuTpl!: NzDropdownMenuComponent;
 
   @Input()
@@ -754,7 +754,7 @@ export class STComponent implements AfterViewInit, OnChanges {
     const data = Array.isArray(newData)
       ? this.dataSource.optimizeData({ columns: this._columns, result: newData })
       : this._data;
-    (newData === true ? from(this.filteredData) : of(data)).subscribe((res: STData[]) =>
+    (newData === true ? this.filteredData : of(data)).subscribe((res: STData[]) =>
       this.exportSrv.export({
         columens: this._columns,
         ...opt,
@@ -818,7 +818,7 @@ export class STComponent implements AfterViewInit, OnChanges {
     return this.orgTable?.cdkVirtualScrollViewport;
   }
 
-  resetColumns(options?: STResetColumnsOption): Observable<this> {
+  private _resetColumns(options?: STResetColumnsOption): Observable<this> {
     options = { emitReload: true, preClearData: false, ...options };
     if (typeof options.columns !== 'undefined') {
       this.columns = options.columns;
@@ -845,6 +845,10 @@ export class STComponent implements AfterViewInit, OnChanges {
     }
   }
 
+  resetColumns(options?: STResetColumnsOption): Promise<this> {
+    return lastValueFrom(this._resetColumns(options));
+  }
+
   private refreshColumns(): this {
     const res = this.columnSource.process(this.columns as _STColumn[], {
       widthMode: this.widthMode,
diff --git a/packages/abc/st/test/st.spec.ts b/packages/abc/st/test/st.spec.ts
index 561347152..04c821de0 100644
--- a/packages/abc/st/test/st.spec.ts
+++ b/packages/abc/st/test/st.spec.ts
@@ -1378,9 +1378,7 @@ describe('abc: st', () => {
           const cls = '.st__body tr[data-index="0"] td';
           page.updateColumn([{ title: '', index: 'name' }]).expectElCount(cls, 1);
           comp.resetColumns({ preClearData: true, columns: [{ title: '', index: 'invalid-name' }] });
-          page.cd();
-          expect(page.comp._data.length).toBe(0);
-          expect(page.get('nz-embed-empty') != null).toBe(true);
+          page.cd().expectElContent(cls, '').asyncEnd();
         }));
       });
       it('#filteredData', fakeAsync(() => {
@@ -1617,7 +1615,6 @@ describe('abc: st', () => {
             <ng-template st-row="id" let-item><div class="j-id">id{{item.id}}</div></ng-template>
           </st>`
       })!;
-      page.cd();
       page.updateColumn([{ title: '', render: 'id' }]).cd();
       const jIdEl = page.getCell().querySelector('.j-id');
       expect(jIdEl != null)

From 98c0b670da6bf528bd9bdf05f81fc374a5ca481a Mon Sep 17 00:00:00 2001
From: cipchk <cipchk@qq.com>
Date: Fri, 4 Aug 2023 17:16:36 +0800
Subject: [PATCH 3/3] chore: fix test

---
 packages/abc/st/st.component.ts | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/packages/abc/st/st.component.ts b/packages/abc/st/st.component.ts
index 790006d50..3959073fc 100644
--- a/packages/abc/st/st.component.ts
+++ b/packages/abc/st/st.component.ts
@@ -113,6 +113,7 @@ export class STComponent implements AfterViewInit, OnChanges {
 
   private destroy$ = inject(DestroyRef);
   private totalTpl = ``;
+  private inied = false;
   cog!: AlainSTConfig;
   private _req!: STReq;
   private _res!: STRes;
@@ -398,13 +399,13 @@ export class STComponent implements AfterViewInit, OnChanges {
         }
         this._data = result.list ?? [];
         this._statistical = result.statistical as STStatisticalResults;
-        this.changeEmit('loaded', result.list);
         // Should be re-render in next tike when using virtual scroll
         // https://github.com/ng-alain/ng-alain/issues/1836
         if (this.cdkVirtualScrollViewport != null) {
           Promise.resolve().then(() => this.cdkVirtualScrollViewport?.checkViewportSize());
         }
         this._refCheck();
+        this.changeEmit('loaded', result.list);
         return this;
       })
     );
@@ -890,20 +891,23 @@ export class STComponent implements AfterViewInit, OnChanges {
   }
 
   ngAfterViewInit(): void {
-    this.columnSource.restoreAllRender(this._columns);
+    this.refreshColumns();
+    if (!this.req.lazyLoad) this.loadPageData().subscribe();
+    this.inied = true;
   }
 
   ngOnChanges(changes: { [P in keyof this]?: SimpleChange } & SimpleChanges): void {
+    if (changes.loading) {
+      this._loading = changes.loading.currentValue;
+    }
+    if (!this.inied) return;
+
     if (changes.columns) {
       this.refreshColumns().optimizeData();
     }
-    const changeData = changes.data;
-    if (changeData && changeData.currentValue && !(this.req.lazyLoad && changeData.firstChange)) {
+    if (changes.data) {
       this.loadPageData().subscribe();
     }
-    if (changes.loading) {
-      this._loading = changes.loading.currentValue;
-    }
   }
 }