Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: correctly use local language in document site #1648

Merged
merged 1 commit into from
Sep 7, 2023
Merged

chore: correctly use local language in document site #1648

merged 1 commit into from
Sep 7, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 7, 2023 •
edited
Loading

Preview is ready!

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1648 (b36c7f3) into master (5dc859e) will not change coverage.
The diff coverage is n/a.

❗ Current head b36c7f3 differs from pull request most recent head 65cf3f9. Consider uploading reports for the commit 65cf3f9 to get more accurate results

@@           Coverage Diff           @@
##           master    #1648   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         281      281           
  Lines        8741     8741           
  Branches     1732     1732           
=======================================
  Hits         8354     8354           
  Misses        319      319           
  Partials       68       68
Files Changed Coverage Δ
packages/theme/src/services/i18n/i18n-url.guard.ts 100.00% <ø> (ø)

@cipchk cipchk merged commit 6648be1 into master Sep 7, 2023
8 checks passed
@cipchk cipchk deleted the issues-site-default-lang branch September 7, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipchk @ng-alain-bot