Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): fix ng update #1714

Merged
merged 9 commits into from
Nov 24, 2023
Merged

chore(cli): fix ng update #1714

merged 9 commits into from
Nov 24, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Nov 24, 2023

Preview is ready!

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7045cec) 94.96% compared to head (d87d559) 94.94%.

Files Patch % Lines
packages/theme/src/provide.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1714      +/-   ##
==========================================
- Coverage   94.96%   94.94%   -0.03%     
==========================================
  Files         316      316              
  Lines        8899     8900       +1     
  Branches     1764     1764              
==========================================
- Hits         8451     8450       -1     
- Misses        377      379       +2     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit a6c860e into master Nov 24, 2023
9 of 11 checks passed
@cipchk cipchk deleted the feat-ng-udpate branch January 1, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants