From 567683f8035f8b95c04d8a915384d54231f1e2fa Mon Sep 17 00:00:00 2001
From: cipchk <cipchk@qq.com>
Date: Fri, 12 Apr 2024 21:29:55 +0800
Subject: [PATCH 1/2] fix(abc:notice-icon): fix incorrect unsubscription

---
 packages/abc/notice-icon/notice-icon.component.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/abc/notice-icon/notice-icon.component.ts b/packages/abc/notice-icon/notice-icon.component.ts
index 834377f82..d7af780d8 100644
--- a/packages/abc/notice-icon/notice-icon.component.ts
+++ b/packages/abc/notice-icon/notice-icon.component.ts
@@ -52,7 +52,7 @@ import { NoticeIconSelect, NoticeItem } from './notice-icon.types';
 export class NoticeIconComponent implements OnInit, OnChanges, OnDestroy {
   private readonly i18n = inject(DelonLocaleService);
   private readonly cdr = inject(ChangeDetectorRef);
-  private i18n$!: Subscription;
+  private i18n$?: Subscription;
   locale: LocaleData = {};
 
   @Input() data: NoticeItem[] = [];
@@ -94,6 +94,6 @@ export class NoticeIconComponent implements OnInit, OnChanges, OnDestroy {
   }
 
   ngOnDestroy(): void {
-    this.i18n$.unsubscribe();
+    this.i18n$?.unsubscribe();
   }
 }

From d71e1d197b8f800d77d51fdc68c20482a8f3bb72 Mon Sep 17 00:00:00 2001
From: cipchk <cipchk@qq.com>
Date: Fri, 12 Apr 2024 21:56:13 +0800
Subject: [PATCH 2/2] ci: fix test

---
 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4a0460400..6322c7333 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -80,7 +80,7 @@ jobs:
         run: yarn install --frozen-lockfile
       - name: Test
         run: yarn run test
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           directory: ./coverage/