Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGCP TRD 4.5.1 EmbankL MCC #5285

Open
tdvorakcaci opened this issue Mar 10, 2022 · 5 comments
Open

MGCP TRD 4.5.1 EmbankL MCC #5285

tdvorakcaci opened this issue Mar 10, 2022 · 5 comments

Comments

@tdvorakcaci
Copy link

Describe the bug
EmbankL (DB090) MCC values are not preserved. Values lost with Hootenanny import. All MCC changed from "Unknown" to "Soil" and MCC changed from "Concrete" to "Unknown".

To Reproduce
MGCP TRD 4.5.1 data imported using Hootenanny and MGCP translation option. "Unknown" values while not desirable, are allowable.

Expected behavior
Preserve MCC attribution. Analysts should determine values.

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

@mattjdnv
Copy link
Contributor

mattjdnv commented Mar 15, 2022

I will have a try with shapefiles but I'm not seeing this in the translation server. Splitting the output over multiple comments for readability.
This script: hoot:/home/dg/hoot/translations $ ./checkSingleFeature.js feeds attributes or tags to the translation server, translates them forwards and backwards looking for differences.

UPDATE: No change with shapefiles.

NOTE: I have Drop Defaults turned OFF.

DB090 Line with concrete
---------------
MGCP  DB090  Line
Raw: {"F_CODE":"DB090","MCC":"21","WID":"5"}
LayerName:   Geometry: Line  Element Type:
In Attrs: F_CODE: :DB090:
In Attrs: MCC: :21:
In Attrs: WID: :5:
LayerName:   Geometry: Line  Element Type:
Out tags: embankment: :yes:
Out tags: material: :concrete:
Out tags: width: :5:

OSM: {"embankment":"yes","material":"concrete","width":"5"}
LayerName:   Geometry: Line  Element Type: Way
In tags: embankment: :yes:
In tags: material: :concrete:
In tags: width: :5:
TableName 0: LDB090  FCode: undefined  Geom: Line
LayerName:   Geometry: Line  Element Type: Way
Out attrs: FCODE: :DB090:
Out attrs: MCC: :21:
Out attrs: WID: :5:

Ogr: {"F_CODE":"DB090","MCC":"21","WID":"5"}
LayerName:   Geometry: Line  Element Type:
In Attrs: FCODE: :DB090:
In Attrs: MCC: :21:
In Attrs: WID: :5:
LayerName:   Geometry: Line  Element Type:
Out tags: embankment: :yes:
Out tags: material: :concrete:
Out tags: width: :5:

OSM: {"embankment":"yes","material":"concrete","width":"5"}
-----

@mattjdnv
Copy link
Contributor

DB090 Line with unknown
---------------
MGCP  DB090  Line
Raw: {"F_CODE":"DB090","MCC":"0","WID":"5"}
LayerName:   Geometry: Line  Element Type:
In Attrs: F_CODE: :DB090:
In Attrs: MCC: :0:
In Attrs: WID: :5:
LayerName:   Geometry: Line  Element Type:
Out tags: embankment: :yes:
Out tags: material: :unknown:
Out tags: width: :5:

OSM: {"embankment":"yes","material":"unknown","width":"5"}
LayerName:   Geometry: Line  Element Type: Way
In tags: embankment: :yes:
In tags: material: :unknown:
In tags: width: :5:
TableName 0: LDB090  FCode: undefined  Geom: Line
LayerName:   Geometry: Line  Element Type: Way
Out attrs: FCODE: :DB090:
Out attrs: MCC: :0:
Out attrs: WID: :5:

Ogr: {"F_CODE":"DB090","MCC":"0","WID":"5"}
LayerName:   Geometry: Line  Element Type:
In Attrs: FCODE: :DB090:
In Attrs: MCC: :0:
In Attrs: WID: :5:
LayerName:   Geometry: Line  Element Type:
Out tags: embankment: :yes:
Out tags: material: :unknown:
Out tags: width: :5:

OSM: {"embankment":"yes","material":"unknown","width":"5"}

@mattjdnv
Copy link
Contributor

DB090 Area with concrete
---------------
MGCP  DB090  Area
Raw: {"F_CODE":"DB090","MCC":"21","TRS":"9"}
LayerName:   Geometry: Area  Element Type:
In Attrs: F_CODE: :DB090:
In Attrs: MCC: :21:
In Attrs: TRS: :9:
LayerName:   Geometry: Area  Element Type:
Out tags: area: :yes:
Out tags: embankment: :yes:
Out tags: material: :concrete:
Out tags: transport:type: :pedestrian:

OSM: {"area":"yes","embankment":"yes","material":"concrete","transport:type":"pedestrian"}
LayerName:   Geometry: Area  Element Type: Way
In tags: area: :yes:
In tags: embankment: :yes:
In tags: material: :concrete:
In tags: transport:type: :pedestrian:
TableName 0: ADB090  FCode: undefined  Geom: Area
LayerName:   Geometry: Area  Element Type: Way
Out attrs: FCODE: :DB090:
Out attrs: MCC: :21:
Out attrs: OSMTAGS: :{"area":"yes"}:
Out attrs: TRS: :9:

Ogr: {"F_CODE":"DB090","MCC":"21","OSMTAGS":"{\"area\":\"yes\"}","TRS":"9"}
LayerName:   Geometry: Area  Element Type:
In Attrs: FCODE: :DB090:
In Attrs: MCC: :21:
In Attrs: OSMTAGS: :{"area":"yes"}:
In Attrs: TRS: :9:
LayerName:   Geometry: Area  Element Type:
Not used: OSMTAGS: :{"area":"yes"}:
LayerName:   Geometry: Area  Element Type:
Out tags: area: :yes:
Out tags: embankment: :yes:
Out tags: material: :concrete:
Out tags: transport:type: :pedestrian:

OSM: {"area":"yes","embankment":"yes","material":"concrete","transport:type":"pedestrian"}

@mattjdnv
Copy link
Contributor

DB090 Area with unknown
---------------
MGCP  DB090  Area
Raw: {"F_CODE":"DB090","MCC":"0","TRS":"9"}
LayerName:   Geometry: Area  Element Type:
In Attrs: F_CODE: :DB090:
In Attrs: MCC: :0:
In Attrs: TRS: :9:
LayerName:   Geometry: Area  Element Type:
Out tags: area: :yes:
Out tags: embankment: :yes:
Out tags: material: :unknown:
Out tags: transport:type: :pedestrian:

OSM: {"area":"yes","embankment":"yes","material":"unknown","transport:type":"pedestrian"}
LayerName:   Geometry: Area  Element Type: Way
In tags: area: :yes:
In tags: embankment: :yes:
In tags: material: :unknown:
In tags: transport:type: :pedestrian:
TableName 0: ADB090  FCode: undefined  Geom: Area
LayerName:   Geometry: Area  Element Type: Way
Out attrs: FCODE: :DB090:
Out attrs: MCC: :0:
Out attrs: OSMTAGS: :{"area":"yes"}:
Out attrs: TRS: :9:

Ogr: {"F_CODE":"DB090","MCC":"0","OSMTAGS":"{\"area\":\"yes\"}","TRS":"9"}
LayerName:   Geometry: Area  Element Type:
In Attrs: FCODE: :DB090:
In Attrs: MCC: :0:
In Attrs: OSMTAGS: :{"area":"yes"}:
In Attrs: TRS: :9:
LayerName:   Geometry: Area  Element Type:
Not used: OSMTAGS: :{"area":"yes"}:
LayerName:   Geometry: Area  Element Type:
Out tags: area: :yes:
Out tags: embankment: :yes:
Out tags: material: :unknown:
Out tags: transport:type: :pedestrian:

OSM: {"area":"yes","embankment":"yes","material":"unknown","transport:type":"pedestrian"}

@mattjdnv
Copy link
Contributor

Adding more attributes.

DB090 Area with unknown and Embankment type
---------------
MGCP  DB090  Area
Raw: {"FIC":"2","F_CODE":"DB090","MCC":"0","TRS":"9"}
LayerName:   Geometry: Area  Element Type:
In Attrs: FIC: :2:
In Attrs: F_CODE: :DB090:
In Attrs: MCC: :0:
In Attrs: TRS: :9:
LayerName:   Geometry: Area  Element Type:
Out tags: area: :yes:
Out tags: embankment: :fill:
Out tags: material: :unknown:
Out tags: transport:type: :pedestrian:

OSM: {"area":"yes","embankment":"fill","material":"unknown","transport:type":"pedestrian"}
LayerName:   Geometry: Area  Element Type: Way
In tags: area: :yes:
In tags: embankment: :fill:
In tags: material: :unknown:
In tags: transport:type: :pedestrian:
TableName 0: ADB090  FCode: undefined  Geom: Area
LayerName:   Geometry: Area  Element Type: Way
Out attrs: FCODE: :DB090:
Out attrs: FIC: :2:
Out attrs: MCC: :0:
Out attrs: OSMTAGS: :{"area":"yes"}:
Out attrs: TRS: :9:

Ogr: {"FIC":"2","F_CODE":"DB090","MCC":"0","OSMTAGS":"{\"area\":\"yes\"}","TRS":"9"}
LayerName:   Geometry: Area  Element Type:
In Attrs: FCODE: :DB090:
In Attrs: FIC: :2:
In Attrs: MCC: :0:
In Attrs: OSMTAGS: :{"area":"yes"}:
In Attrs: TRS: :9:
LayerName:   Geometry: Area  Element Type:
Not used: OSMTAGS: :{"area":"yes"}:
LayerName:   Geometry: Area  Element Type:
Out tags: area: :yes:
Out tags: embankment: :fill:
Out tags: material: :unknown:
Out tags: transport:type: :pedestrian:

OSM: {"area":"yes","embankment":"fill","material":"unknown","transport:type":"pedestrian"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants