From d6321f8f53485ddc899a0c982be181c1b9813930 Mon Sep 17 00:00:00 2001 From: "Robert St. John" Date: Thu, 26 Oct 2023 12:44:28 -0600 Subject: [PATCH] [service][web-app] make saml cert required, because passport-saml now requires cert --- service/src/authentication/saml.js | 5 +---- .../admin-authentication-create.component.ts | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/service/src/authentication/saml.js b/service/src/authentication/saml.js index 1a7484393..2c33bae42 100644 --- a/service/src/authentication/saml.js +++ b/service/src/authentication/saml.js @@ -15,12 +15,9 @@ function configure(strategy) { const options = { path: `/auth/${strategy.name}/callback`, entryPoint: strategy.settings.entryPoint, + cert: strategy.settings.cert, issuer: strategy.settings.issuer } - - if (strategy.settings.cert) { - options.cert = strategy.settings.cert; - } if (strategy.settings.privateCert) { options.privateCert = strategy.settings.privateCert; } diff --git a/web-app/src/app/admin/admin-authentication/admin-authentication-create/admin-authentication-create.component.ts b/web-app/src/app/admin/admin-authentication/admin-authentication-create/admin-authentication-create.component.ts index fc5a4ac69..837f6eff0 100644 --- a/web-app/src/app/admin/admin-authentication/admin-authentication-create/admin-authentication-create.component.ts +++ b/web-app/src/app/admin/admin-authentication/admin-authentication-create/admin-authentication-create.component.ts @@ -47,7 +47,7 @@ export class AuthenticationCreateComponent implements OnInit { oauth: ['clientSecret', 'clientID', 'authorizationURL', 'tokenURL', 'profileURL'], openidconnect: ['clientSecret', 'clientID', 'issuer', 'authorizationURL', 'tokenURL', 'profileURL'], ldap: ['url'], - saml: ['entryPoint'] + saml: ['entryPoint', 'cert'] } constructor(