Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ChangeProcessor and EventHandler #525

Open
pleshakov opened this issue Apr 4, 2023 · 0 comments
Open

Simplify ChangeProcessor and EventHandler #525

pleshakov opened this issue Apr 4, 2023 · 0 comments
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. tech-debt Short-term pain, long-term benefit

Comments

@pleshakov
Copy link
Contributor

Remove CaptureUpsertChange() and CaptureDeleteChange() from ChangeProcessor and pass all changes directly to
Process() instead. As a result, the clients will only need to call Process(), which will simplify them.
Now the clients make a combination of CaptureUpsertChange() and CaptureDeleteChange() calls followed by a call to
Process().

See https://github.com/nginxinc/nginx-kubernetes-gateway/blob/d121ff136620844826ae5d20024e876af6c99119/internal/state/change_processor.go#L181

@pleshakov pleshakov added proposal tech-debt Short-term pain, long-term benefit labels Apr 4, 2023
@ja20222 ja20222 added backlog Currently unprioritized work. May change with user feedback or as the product progresses. and removed proposal labels Apr 5, 2023
@pleshakov pleshakov self-assigned this Apr 21, 2023
@pleshakov pleshakov removed their assignment Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. tech-debt Short-term pain, long-term benefit
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants