Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-dupe http matches #662

Open
kate-osborn opened this issue May 23, 2023 · 0 comments
Open

De-dupe http matches #662

kate-osborn opened this issue May 23, 2023 · 0 comments
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. tech-debt Short-term pain, long-term benefit

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented May 23, 2023

When creating certain configurations such as multiple listeners with no hostnames, and having an httproute bind to all listeners, it can result in duplicate http matching configs. While this result doesn't cause any issues, it results in nginx and our njs module doing extra work that they don't need to be doing.

We should ensure that we de-duplicate our http matches before updating nginx.

Example: #885 (comment)

@sjberman sjberman changed the title Placeholder FIXME: "De-dupe matches and associated locations" De-dupe http matches May 23, 2023
@sjberman sjberman added tech-debt Short-term pain, long-term benefit and removed proposal labels May 25, 2023
@mpstefan mpstefan added this to the v1.0.0 milestone Jun 29, 2023
@sjberman sjberman removed their assignment Jul 20, 2023
@mpstefan mpstefan modified the milestones: v1.0.0, v1.0.1 Aug 11, 2023
@mpstefan mpstefan modified the milestones: v1.0.1, v1.3.0 Sep 22, 2023
@mpstefan mpstefan added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Mar 13, 2024
@mpstefan mpstefan modified the milestone: v1.3.0 Mar 13, 2024
@mpstefan mpstefan removed the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Mar 20, 2024
@mpstefan mpstefan modified the milestones: v1.3.0, v1.4.0 May 1, 2024
@mpstefan mpstefan removed this from the v1.4.0 milestone Jul 24, 2024
@mpstefan mpstefan added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. tech-debt Short-term pain, long-term benefit
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants