From 4194a63b4f080a7c48af6f41afe56cf2970a4f85 Mon Sep 17 00:00:00 2001 From: Saylor Berman Date: Wed, 19 Jul 2023 08:52:01 -0600 Subject: [PATCH] Remove FIXME for de-duping matches Per the ticket, I'm not able to reproduce the issue. It may have been fixed already, so closing out the ticket and removing the FIXME. If it pops up again in the future, we can reopen. --- internal/mode/static/nginx/config/servers.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/mode/static/nginx/config/servers.go b/internal/mode/static/nginx/config/servers.go index 63e99b30f2..4d88702032 100644 --- a/internal/mode/static/nginx/config/servers.go +++ b/internal/mode/static/nginx/config/servers.go @@ -425,9 +425,6 @@ func convertSetHeaders(headers []dataplane.HTTPHeader) []http.Header { } func convertMatchesToString(matches []httpMatch) string { - // FIXME(sberman): De-dupe matches and associated locations - // so we don't need nginx/njs to perform unnecessary matching. - // https://github.com/nginxinc/nginx-kubernetes-gateway/issues/662 b, err := json.Marshal(matches) if err != nil { // panic is safe here because we should never fail to marshal the match unless we constructed it incorrectly.