Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build instructions incorrect since 1.0.0 #620

Closed
wrossmann opened this issue Feb 2, 2024 · 0 comments · Fixed by #621
Closed

Build instructions incorrect since 1.0.0 #620

wrossmann opened this issue Feb 2, 2024 · 0 comments · Fixed by #621
Labels
backlog Pull requests/issues that are backlog items good first issue Issues identified as good for first-time contributors
Milestone
v1.2.0

Comments

@wrossmann
Copy link

wrossmann commented Feb 2, 2024 •
edited
Loading

Describe the bug

#505 added a help target to the Makefile, but added it to the top, making it the default target.

Either the help target needs to be moved elsewhere, or README.md needs to be changed to reflect that the basic build command is make nginx-prometheus-exporter.
@lucacome lucacome added good first issue Issues identified as good for first-time contributors backlog Pull requests/issues that are backlog items labels Feb 2, 2024
@dominikwinter dominikwinter mentioned this issue Feb 3, 2024
Merged
6 tasks
@lucacome lucacome added this to the v1.2.0 milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Pull requests/issues that are backlog items good first issue Issues identified as good for first-time contributors
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Restore the old behavior when 'nginx-prometheus-exporter' was the default rule for make
2 participants
@lucacome @wrossmann