Trying to implement a computed store feature

[caboodal]

I've defined the following store feature but when I use this within my store I get compile errors the first one of which is "No overload matches this call." as per usual the error reported is so huge it's very difficult to work out what the root of the problem is. As my store works with the withComputed added as a normal withComputed but then errors with that replaced with the below feature I assume there is something wrong with the code below.

import {signalStoreFeature, type, withComputed} from "@ngrx/signals";
import {PagedListResponseState} from "../../../state/paged-list-response-state";
import {computed} from "@angular/core";

export function withResults<T>() {
    return signalStoreFeature(
        { state: type<PagedListResponseState<T>>() },
        withComputed((state) => ({
            results: computed((): Array<T> => {
                return state.response.results();
            })
        }))
    )
}

[caboodal]

OK it's being caused by the fact that I'm only passing in part of the state type, if I use the complete state type the error goes away i.e. { state: type<UserState>() }, but this defeats the object of moving it to a feature so I can share it amongst other list pages. I've not had the same issue with create method store features.

My user state is made up of the following 3 elements, and my withResults feature only needs access to the PagedListResponseState<T> portion.

export type UserState = {
    filterParams: ListFilterParameters;
} & PagedListQueryState & PagedListResponseState<ListUserResponse>;

[caboodal]

If I change the feature creation function as below and then call the withResults like this withResults<ListFundingProviderResponse>() I get the error but if I call it like this ``withResults()` I get no errors and it works.

import {signalStoreFeature, type, withComputed} from "@ngrx/signals";
import {computed} from "@angular/core";
import {PagedListResponseState} from "../../../state/paged-list-response-state";

export function withResults<T>() {
    return signalStoreFeature(
        { state: type<PagedListResponseState<T>>() },
        withComputed(({response}) => ({
            results: computed((): Array<T> => {
                return response.results();
            })
        }))
    )
}

[caboodal]

If I can just remove the generic type and everything will still work as expected then I guess that's an easier solution and keeps the code cleaner.

Thank you for the heads up on using signal state, I'll review the documentation in the links.

[caboodal]

If I remove the generic typing on withResults and withApplyFirst I get compile errors.

[markostanimirovic]

The Angular project you shared is incomplete - it cannot be cloned and run because package.json, angular.json, etc. are missing.

When I cloned it, I added package.json, installed dependencies, and when I removed explicit generic usages error warnings in the IDE disappeared.

[markostanimirovic]

Take a look: https://stackblitz.com/edit/github-8kstl6?file=state%2Ftest-store.ts

angular.json is missing so the application cannot be started, but when dependencies are installed, error warnings will disappear in test-store.ts when explicit generics are removed from withResults and withApplyFirst.