Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Dockerize your angular app" option to the setup wizard. #327

Open
1 of 3 tasks
kenan435 opened this issue May 25, 2018 · 7 comments
Open
1 of 3 tasks

Add "Dockerize your angular app" option to the setup wizard. #327

kenan435 opened this issue May 25, 2018 · 7 comments

Comments

@kenan435
Copy link

kenan435 commented May 25, 2018

I would like to be prompted in the ngx setup wizard if I would like to "Dockerize" the angular app. This would create docker files for dev and production. In the case of prod; ask which prod web server I would like to use (Apache, nginx etc...). We could have a task (npm start --docker) which builds the image and runs it inside of a docker container mounting the local src, node_module folders so that we can hot-reload changes while writing our app.

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request

Current behaviour

Currently there is no support for dockerizing angular apps.

Expected behaviour

Would like to automate the Dockerzing of angular app for dev and prod purposes.

@sinedied
Copy link
Member

Sure that would be nice, I think it would be a great fit for an add-on 👍

@kenan435
Copy link
Author

OK, i'll take it...

@duydnguyen07
Copy link

@kenan435 Are you thinking of using nginx to host the app container or expressJs, or something else?

@sinedied
Copy link
Member

Closing this one, as it seems official support via ng CLI is coming: https://github.com/angular/angular-cli/blob/master/docs/design/docker-deploy.md

sinedied pushed a commit that referenced this issue Mar 27, 2020
# [8.0.0](7.1.0...8.0.0) (2020-03-27)

### Bug Fixes

* broken template ([68d287e](68d287e))
* i18n for Electron ([15c7615](15c7615))
* i18n language imports ([0b8a1a6](0b8a1a6))
* ionic css import ([2a4b5cd](2a4b5cd))
* jest alias and update cases for prefix ([6f84b73](6f84b73))
* languages listing on windows ([37d5656](37d5656))
* material header not showing in cordova (close [#215](#215), [#511](#511)) ([2b78ff0](2b78ff0))
* misplaced prompt for puppeteer ([5cb4b60](5cb4b60))
* missing global mock when using Jest ([#509](#509)) ([32c69cf](32c69cf))
* stylelint issue ([451b47b](451b47b))
* template issues ([046fd48](046fd48))
* ts error with cordova ([9ae8b51](9ae8b51))
* webview config for ios/android (close [#491](#491)) ([79f4e49](79f4e49))

### Features

* add de-DE translation ([f08f6ec](f08f6ec))
* add deployment options (close [#540](#540), [#327](#327)) ([7602e8c](7602e8c))
* add i18n module and language selection at generation (close [#262](#262)) ([383d6fb](383d6fb))
* add prefix and aliasing for core/shared (close [#277](#277)) ([faa1981](faa1981))
* aggregate all auth related components in auth module (close [#535](#535)) ([8dbadb7](8dbadb7))
* make Angular Material the default UI for web apps ([626505c](626505c))
* remove HttpService and CacheService ([99eea62](99eea62))
* remove usage of puppeter by default for testing (fix [#522](#522)) ([b786c23](b786c23))
* update bootstrap template for ng9 ([88d3d58](88d3d58))
* update de-DE translation ([3c0b244](3c0b244))
* update to Ionic 5 ([589a1fb](589a1fb))
* upgrade to ng9 for material path ([97d8fb0](97d8fb0))

### BREAKING CHANGES

* core/shared folders now have an `@` prefix to have them listed first,
along with a direct TypeScript alias for imports.
* Removing HttpClient overload as this is definitely not something
the Angular team is looking to support. Also it's not relevant and
useful anymore thanks to state management libraries, that's why
CacheService is also removed.
@AndreKoepke
Copy link

@sinedied your link is dead. I think, they moved the functionality to ngx-deploy-docker, but I found no documentation about it. Only this commit: angular/angular-cli@245e669

Maybe rocket can just add the ngx-deploy-docker?

@sinedied sinedied reopened this Feb 21, 2022
@sinedied
Copy link
Member

This might be a good idea, since official support seems to have been dropped.
Are you willing to submit a PR for it?

This could be added to other deployment option, and as ngx-deploy-docker supports ng add it should be a straightforward addition.

@AndreKoepke
Copy link

I'm discovered ngx-rocket and ngx-deploy-docker today for the first time. :D
I will try it, but I can't make any promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants