Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngx-extractor fails on invocations with dynamic initializers #39

Open
ANeumann82 opened this issue Sep 21, 2018 · 0 comments
Open

ngx-extractor fails on invocations with dynamic initializers #39

ANeumann82 opened this issue Sep 21, 2018 · 0 comments

Comments

@ANeumann82
Copy link

I have a couple of dynamic translations that are not supposed to be extracted ( as the values are coming from the backend anyway), and the extractor fails to ignore them.

this.i18n({id: 'somefancyprefix' + keyFromBackend, value: 'SomeValueAsWeJustNeedThem' + keyFromBackend});

If i were to use just a variable as a parameter, or a constant, the extractor works ok, but with dynamic initalizers it fails.
ANeumann82 pushed a commit to ANeumann82/i18n-polyfill that referenced this issue Sep 21, 2018
ngx-translate#39 Fixed issue with dynamic initializers in extractor
f21bcee
ANeumann82 pushed a commit to ANeumann82/i18n-polyfill that referenced this issue Sep 21, 2018
ngx-translate#39 Added test method that describes the issue and would…
6f30141 
… fail without the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ANeumann82