Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationProvider.Current shouldn't depend on IConfigurationSectionHandler from System.Configuration.ConfigurationManager #120

Open
bahusoid opened this issue Apr 11, 2023 · 0 comments · May be fixed by #121
Open

ConfigurationProvider.Current shouldn't depend on IConfigurationSectionHandler from System.Configuration.ConfigurationManager #120

bahusoid opened this issue Apr 11, 2023 · 0 comments · May be fixed by #121

Comments

@bahusoid
Copy link
Member

bahusoid commented Apr 11, 2023 •
edited
Loading

NHibernate-Caches/NHibernate.Caches.Common/ConfigurationProviderBase.cs

Lines 28 to 32 in 196296f

public static ConfigurationProviderBase<TConfig, TConfigHandler> Current
{
get => _current ?? (_current = new StaticConfigurationManagerProvider());
set => _current = value ?? new NullConfigurationProvider();
}

It's quite strange that user custom implementation not using xml still needs dependency on this xml related class from nuget package:

public class CoreDistributedCacheCustomConfigProvider : ConfigurationProviderBase<CacheConfig,CoreDistributedCacheSectionHandler>
@bahusoid bahusoid changed the title 'ConfigurationProvider.Current' shouldn't depend on IConfigurationSectionHandler from System.Configuration.ConfigurationManager ConfigurationProvider.Current shouldn't depend on IConfigurationSectionHandler from System.Configuration.ConfigurationManager Apr 11, 2023
@bahusoid bahusoid linked a pull request Apr 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bahusoid