NHibernate.Engine.ActionQueue.ExecuteAsync hides TaskCanceledException

[Madajevas]

If provided cancellation token gets cancelled during execution of InnerExecuteAsync method and any listener code checks token and throws exception it gets lost because regardless of cancellation token state finally block gets executed where PreInvalidateCachesAsync method checks token again and throws exception of its own. I would advice to not call that method if cancellation was requested and allow exception to bubble.

nhibernate-core/src/NHibernate/Async/Engine/ActionQueue.cs

Lines 55 to 66 in 8a1b084

	public async Task ExecuteAsync(IExecutable executable, CancellationToken cancellationToken)
	{
	cancellationToken.ThrowIfCancellationRequested();
	try
	{
	await (InnerExecuteAsync(executable, cancellationToken)).ConfigureAwait(false);
	}
	finally
	{
	await (PreInvalidateCachesAsync(cancellationToken)).ConfigureAwait(false);
	}
	}

[hazzik]

Thanks. Good catch.

@maca88, we would probably need to change the async generator to account for this situations.