feat(nhost_sdk): Allow metadata to be passed in signInWithSmsPassword… #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spakanati Thank you for the PR 🙌! Looking at it now. |
dbarrosop
previously approved these changes
Nov 30, 2023
|
Hey @spakanati, I'm trying to include the other options as well not only the metadata. But I can't push to your repo because of permissions. If you can fix this on your end that would be great! 
|
|
@onehassan I just added you as a collaborator -- please let me know if you're able to push! Thanks so much for looking. |
|
Thank you @spakanati 🙌 , I was able to push changes. Will merge soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
Please note that I didn't add a test because currently the tests for SMS say "cannot meaningfully test" but please let me know if there is something that would be useful to add.