Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packager isn't checking the plug-in directory for an UI file #26

Open
jayaseelan-james opened this issue Nov 27, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jayaseelan-james
Copy link
Collaborator

jayaseelan-james commented Nov 27, 2024

Bug Report

The packager tool proceeds to package a measurement plug-in directory when the directory is missing a UI file (*.measui or *.vi). AB#2943085

Steps to reproduce

  1. Use any of the examples from the measurement-plugin-python repo. Example: ni_dcpower_source_dc_voltage
  2. Delete the ".measui" file from the directory.
  3. Use the tool to package the measurement plug-in directory without the .serviceconfig file.

Expected Behavior

  • Throws an error indicating that the plug-in directory is missing a UI file (*.measui or *.vi).

Current Behavior

  • Packages the directory without any error.
    image
    image

Possible Solution

  • Like pyproject.toml, measurement.py and start.bat, ensure that the directory contains a UI file.

Context

  • Testing the ni-measurement-plugin-packager 1.3.0

Your Environment

  • OS & Device: Windows on PC
  • ni-measurement-plugin-packager version 1.3.0
  • nisystemlink-feeds-manager version 1.0.0.dev1
  • ni-measurement-plugin-sdk-service version 2.1.0
  • InstrumentStudio version 2024 Q4
  • Python version 3.9
@jayaseelan-james jayaseelan-james added the bug Something isn't working label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant