Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add minimal client implementation for Feeds API #73

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

feat: Add minimal client implementation for Feeds API #73

wants to merge 44 commits into from

Conversation

Giriharan219
Copy link
Collaborator

@Giriharan219 Giriharan219 commented Oct 24, 2024 •
edited
Loading

What does this Pull Request accomplish?

This PR adds some client methods for feeds endpoints and testing for these endpoints.

Why should this Pull Request be merged?

This Minimal client for feeds APIs and will enable users to more easily interact with that APIs.

What testing has been done?

Auto testing is included against NI's test tier.

API Link: Swagger-link

jayaseelan-james
jayaseelan-james reviewed Oct 24, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jayaseelan-james
jayaseelan-james approved these changes Oct 24, 2024
View reviewed changes
Copy link

@jayaseelan-james jayaseelan-james left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the general Python standards.

nisystemlink/clients/auth/models/_auth_models.py Outdated Show resolved Hide resolved
nisystemlink/clients/auth/models/_auth_models.py Outdated Show resolved Hide resolved
nisystemlink/clients/auth/models/_auth_models.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Outdated Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Outdated Show resolved Hide resolved
santhoshramaraj
santhoshramaraj reviewed Oct 24, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
santhoshramaraj
santhoshramaraj reviewed Oct 24, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
santhoshramaraj
santhoshramaraj requested changes Oct 24, 2024
View reviewed changes
tests/integration/auth/test_auth_client.py Outdated Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Outdated Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Outdated Show resolved Hide resolved
docs/getting_started.rst Outdated Show resolved Hide resolved
docs/getting_started.rst Outdated Show resolved Hide resolved
docs/getting_started.rst Outdated Show resolved Hide resolved
docs/getting_started.rst Outdated Show resolved Hide resolved
@santhoshramaraj santhoshramaraj changed the title Minimal implementation of Feeds and Auth API feat: Add client for Feeds API Oct 25, 2024
@Giriharan219
feat: add feeds api with examples and wrapper files
88716eb
@Giriharan219
feat: separte function for query feeds
074f782
@Giriharan219
docs: Update doc strings
590d91c
@Giriharan219
fix: Update upload mulitple package function
f4f06e0
@Giriharan219
fix: errors due to mypy checks
5d80d06
@Giriharan219
docs: Update rst files for auth and feeds client
7dda9c7
@Giriharan219
fix: Update file names and client name for feeds client
785eb39
@Giriharan219
feat: add pytest for feeds and auth apis
8392e0b
@Giriharan219
fix: mypy and black issues
d90ab93
@Giriharan219
fix: remove hardcoded workspace in pytest for feeds
facf591
@Giriharan219
docs: update api ref rst file
c8aa6eb
@Giriharan219
docs: update getting started rst file
37ebd69
@Giriharan219
fix: err due to invalid path in getting started.rst file
5d41864
@Giriharan219
fix: remove unwanted helpers
11beed3
@Giriharan219
fix: Address self review comments
0690f73
@Giriharan219
docs: alignment in the rst files
734429b
@Giriharan219
fix: address second set of self review comments
480e410
@Giriharan219
docs: Update doc string of auth models
1c01493
@Giriharan219
feat: add delete feed api
fc06d3a
santhoshramaraj
santhoshramaraj requested changes Oct 30, 2024
View reviewed changes
examples/feeds/create_feed.py Outdated Show resolved Hide resolved
examples/feeds/delete_feed.py Outdated Show resolved Hide resolved
examples/feeds/query_and_upload_feeds.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Show resolved Hide resolved
nisystemlink/clients/feeds/utilities.py Outdated Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Show resolved Hide resolved
@Giriharan219 Giriharan219 force-pushed the users/gravichandran/systemlink-feeds branch from b716231 to 8edf916 Compare November 4, 2024 08:36
santhoshramaraj
santhoshramaraj requested changes Nov 4, 2024
View reviewed changes
examples/feeds/delete_feed.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/_feeds_client.py Outdated Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Outdated Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Outdated Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Show resolved Hide resolved
tests/integration/feeds/test_feeds_client.py Show resolved Hide resolved
@Giriharan219 Giriharan219 force-pushed the users/gravichandran/systemlink-feeds branch 2 times, most recently from a24473f to 9b09f9f Compare November 5, 2024 14:01
@Giriharan219 Giriharan219 force-pushed the users/gravichandran/systemlink-feeds branch from 9b09f9f to 44472b7 Compare November 5, 2024 16:17
santhoshramaraj
santhoshramaraj approved these changes Nov 6, 2024
View reviewed changes
nisystemlink/clients/feeds/models/_feed.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/models/_feed.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/models/_package.py Outdated Show resolved Hide resolved
nisystemlink/clients/feeds/utilities.py Outdated Show resolved Hide resolved
@Giriharan219 Giriharan219 force-pushed the users/gravichandran/systemlink-feeds branch from fb25866 to db529c8 Compare November 7, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayaseelan-james jayaseelan-james jayaseelan-james approved these changes

@santhoshramaraj santhoshramaraj santhoshramaraj approved these changes

@mure mure Awaiting requested review from mure mure is a code owner

@spanglerco spanglerco Awaiting requested review from spanglerco spanglerco is a code owner

@cameronwaterman cameronwaterman Awaiting requested review from cameronwaterman cameronwaterman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Giriharan219 Giriharan219

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Giriharan219 @santhoshramaraj @jayaseelan-james