Are you interested in contributing to ShapeScript? Fantastic!
Here's what you need to know:
ShapeScript follows a variant of Semantic Versioning (semver). 1.0.x releases are for bug fixes and purely additive features, 1.x.0 releases are for breaking changes (under normal semver rules, x.0.0 would be used for breaking changes).
Since ShapeScript is an asset creation tool and scripting language implementation as well as a framework, "breaking changes" refers to the interpreted script format and generated geometry as well as the API. Changes to the way scripts are interpreted and/or how geometry is generated by a given function may be considered to be breaking, even if they do not affect the Swift framework API itself.
Making your first pull request can be scary. If you have trouble with any of the contribution rules, make a pull request anyway. A PR is the start of a process not the end of it.
All types of PR are welcome, but please do read these guidelines carefully to avoid wasting your time and ours. If you are planning something big, or which might be controversial, it's a great idea to create an issue first to discuss it before writing a lot of code.
Types of PR:
-
Documentation fixes - if you've found a typo, or incorrect comment, either in the README or a code comment, feel free to create a PR directly against the main branch.
-
Minor code fixes - a typo in a method name or a trivial bug fix should be made against the develop branch.
-
Major code changes - significant refactors or new functionality should usually be raised as an issue first to avoid wasted effort on a PR that's unlikely to land. This is mainly for your own sake, not ours, so if you prefer to make suggestions in code form then that's fine too. As with fixes, PRs should be made against the develop branch.
Any new source files that you add should include the standard license header used in all the existing files. You may include your own name as the author for files that you created or replaced.
By contributing code to ShapeScript, you are implicitly agreeing to license it under the terms described in the LICENSE.md file. Please do not submit code that you did not write or are not authorized to redistribute.
Inclusion of 3rd party frameworks is not permitted, regardless of the license. Small sections of code copied from somewhere else may be acceptable, provided that the terms of the original license are compatible with ShapeScript's LICENSE.md, and that you include a comment linking back to the source.
ShapeScript's source code mostly follows the Ray Wenderlich Style Guide very closely with the following exception:
- Use the Xcode default of 4 spaces for indentation.
Code should be commented, but not excessively. In general, comments should follow the principle of why, not what, but it's acceptable to use "obvious" comments as headings to break up large blocks of code. Public methods and classes should be commented using the /// headerdoc style.
When making user-facing changes, please update the README.md file if applicable. There is no need to update CHANGELOG.md or bump the version number.
All significant code changes should be accompanied by a test.
Tests are run automatically on all pull requests, branches and tags. These are the same tests that run in Xcode at development time.
There will be zero tolerance for rudeness or bullying. If you think somebody else's comment or pull request is stupid, keep it to yourself. If you are frustrated because your issue or pull request isn't getting the attention it deserves, feel free to post a comment like "any update on this?", but remember that we are all busy, and other peoples' priorities don't necessarily match yours.
Abusive contributors will be blocked and/or reported, regardless of how valuable their code contributions may be.