Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nondeterministic disambiguation #163

Open
nielstron opened this issue Sep 16, 2020 · 0 comments
Open

Nondeterministic disambiguation #163

nielstron opened this issue Sep 16, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nielstron
Copy link
Owner

Describe the bug
As mentioned in #161, for some inputs the output of the disambiguation tool seems nondeterministic. This is undesired behaviour.

To Reproduce
Results for "1mw"

Expected behavior
Always return either "milliwatt" or "megawatt", however not random ones.

Additional information:

  • Classifier activated/ sklearn installed: yes

Additional context
As pointed out in #162 , by running next(iter(..)) the entity and unit disambiguation may be non-deterministic
@nielstron nielstron added bug Something isn't working good first issue Good for newcomers labels Sep 16, 2020
hwalinga added a commit to hwalinga/quantulum3 that referenced this issue Sep 16, 2020
@hwalinga
Have determistic output when multiple things match. Addresses nielstr…
94a6afd 
…on#163.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nielstron