You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'll work on those enhancements soon. Please let me know what you think about migrating to poetry and maybe possibly migrating tests to pytest to make them easier to read and work with. @niklasf
The text was updated successfully, but these errors were encountered:
bswck
changed the title
Code refactor
Code refactor, meta stuff
Jul 24, 2023
(1), (2), (3): Sure, if the new code would be more readable. For (2), the code was ported line by line from a C original. It has since diverged, so I'd be fine with giving up the 1:1 correspondence and make it look more like Python code.
(4) will only be merged after Python 3.9 is past its end of life.
(5): There are no dependencies :)
(6), (7): Sure, if the findings make sense.
For pytest, at a glance I don't see how it would improve dx for this project. Do you have any particular features in mind?
About (4), I think as long as you import from __future__ importannotations, you should be able to use the new syntax just fine, we use it on berserk and support 3.8
.format()
and f-string methods are used)Some algorithms do need logic refactoring, for instance
python-chess/chess/syzygy.py
Lines 323 to 352 in f76c387
which could simply be truncated into
I'll work on those enhancements soon. Please let me know what you think about migrating to poetry and maybe possibly migrating tests to pytest to make them easier to read and work with. @niklasf
The text was updated successfully, but these errors were encountered: