Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python < 3.10 not supported #23

Open
berghton opened this issue Nov 27, 2024 · 2 comments
Open

Python < 3.10 not supported #23

berghton opened this issue Nov 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@berghton
Copy link

Hi,

Thanks for this great library!

It seems like python < 3.10 is not supported by the library. The issue is with the | operator in the type hints. I believe that operator for type hints was introduced in python 3.10. Also tuple in type hints were introduced in python 3.9.

So if you want to support more python versions you could use Union, Optional and Tuple from the typing library instead. It would definitely help me, and perhaps others as well.

@hanspayer
Copy link

hanspayer commented Nov 27, 2024

I really like your solution. I'm using 3.9 and the type hinting with the pipe operator is not supported. That would help here too.

@niklashenning niklashenning added the bug Something isn't working label Nov 27, 2024
@niklashenning
Copy link
Owner

Hi, thanks for letting me know! I'll change this in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants