-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
name clashes with imported package functions #1469
Comments
Only partly related, but we might only import the functions from |
Here's my thought on how to handle this.
We may need to do this in various places so we may want to create our own Here's some initial code:
@perrydv let's discuss. |
One more note that is with something like the In general, we'd presumably favor getting the RC function from the global env. |
Interestingly the name clash does not occur for nimbleFunctions in other packages. E.g., one can use We'd need to think about cases where an RC function might be coming from another package, presumably favoring the global env. And a note that if a user tries to re-use the name of an RC function in nimble, such as
|
When a user defines a nimbleFunction with the same name as an imported function,
compileNimble
will fail due to finding the imported function name first. Here is a reprex adapted from a nimble-users message:The problem is that the search for
normalize
findsigraph::normalize
because that is imported into nimble's namespace.We could refine how nimbleFunctions are found (although this has been not as simple as it seems in the past) or at least revise the error message to suggest possible name clashes.
The text was updated successfully, but these errors were encountered: