Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macro-related naming and option #1491

Open
paciorek opened this issue Oct 5, 2024 · 1 comment
Open

macro-related naming and option #1491

paciorek opened this issue Oct 5, 2024 · 1 comment

Comments

@paciorek
Copy link
Contributor

paciorek commented Oct 5, 2024

@kenkellner @perrydv
We agreed to change:

  • enableModelMacros -> enableMacros
  • model_macro_builder -> buildModelMacro

Given we are omitting "Model" from enableModelMacros, perhaps we should go with buildMacro?

Also I have a note to myself for version 1.3.0 to "turn model macros on with nimbleOption".
But I think we already have this via the enableModelMacros option. Do either of you remember if there were something more here?

@kenkellner
Copy link
Contributor

I like buildMacro.

I don't remember specifically, but maybe the note was to turn on enableModelMacros by default at some point? Right now I believe the option is off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants