Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests that make sure ZKP keys stay compatible #2718

Open
paberr opened this issue Jun 28, 2024 · 0 comments
Open

Create tests that make sure ZKP keys stay compatible #2718

paberr opened this issue Jun 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@paberr
Copy link
Member

paberr commented Jun 28, 2024

The ZKP circuits require very specific serialization of the MacroBlock.
In particular, it assumes the body is hashed as hash(pk_tree_root || body_bytes), where body_bytes is 64 bytes long.
The header is hashed as hash(network || version || block_number || intermediate_header_bytes || body_hash || history_root) where intermediate_header_bytes is exactly 4+8+32+32+32+96+32+32=268 bytes long.

We should create tests that make sure we don't change these constraints by accident.

@paberr paberr added the enhancement New feature or request label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant