Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow paging for transactions-by-address queries #2733

Closed
2 tasks
sisou opened this issue Jul 9, 2024 · 1 comment · Fixed by #2940
Closed
2 tasks

Allow paging for transactions-by-address queries #2733

sisou opened this issue Jul 9, 2024 · 1 comment · Fixed by #2940
Assignees
@paberr
Labels
enhancement New feature or request
Milestone
Nimiq PoS Mainnet

Comments

@sisou
Copy link
Member

sisou commented Jul 9, 2024

As @paberr recently discovered, the tree structure we use for the transaction store lends itself to efficiently request transactions with an offset.

This option should be added to the RPC API, and then to the relevant protocol message.

  • offset in RPC get_transactions_by_address
  • offset in protocol receipts message

The change to the message will be a protocol breaking change.
@sisou sisou added the enhancement New feature or request label Jul 9, 2024
@paberr
Copy link
Member

paberr commented Jul 12, 2024

I think this is a duplicate of #2697

@paberr paberr mentioned this issue Jul 12, 2024
Closed
2 tasks
@paberr paberr self-assigned this Sep 27, 2024
@paberr paberr mentioned this issue Sep 27, 2024
Merged
3 tasks
@paberr paberr linked a pull request Sep 27, 2024 that will close this issue
Implement pagination by tx hash for requesting of transaction history #2940
Merged
3 tasks
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paberr paberr

Labels
enhancement New feature or request
Projects
None yet
Milestone
Nimiq PoS Mainnet
Development

Successfully merging a pull request may close this issue.

Implement pagination by tx hash for requesting of transaction history nimiq/core-rs-albatross
3 participants
@sisou @jsdanielh @paberr