Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mempool transaction verification is wrapped in spawn_blocking #2852

Closed
Eligioo opened this issue Aug 26, 2024 · 2 comments
Closed

Mempool transaction verification is wrapped in spawn_blocking #2852

Eligioo opened this issue Aug 26, 2024 · 2 comments
Assignees
@styppo
Labels
enhancement New feature or request
Milestone
Nimiq PoS Mainnet

Comments

@Eligioo
Copy link
Member

Eligioo commented Aug 26, 2024

This is probably redundant
https://github.com/nimiq/core-rs-albatross/blob/albatross/mempool/src/verify.rs#L43-L47
@Eligioo Eligioo added the enhancement New feature or request label Aug 26, 2024
@Eligioo
Copy link
Member Author

Eligioo commented Aug 27, 2024

Additionally, the default for max_blocking_threads (link) for the Tokio runtime is 512 thus concurrently verifying more than this number currently probably doesn't work as expected.

@styppo styppo self-assigned this Sep 4, 2024
@styppo
Copy link
Member

styppo commented Oct 18, 2024

Fixed in cee38d8

@styppo styppo closed this as completed Oct 18, 2024
@jsdanielh jsdanielh added this to the Nimiq PoS Mainnet milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@styppo styppo

Labels
enhancement New feature or request
Projects
None yet
Milestone
Nimiq PoS Mainnet
Development

No branches or pull requests
3 participants
@jsdanielh @styppo @Eligioo