Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

重複する機能を削除: Excelivnoice読み取り機能 #36

Open
sonoh5n opened this issue Sep 11, 2024 · 0 comments
Open

重複する機能を削除: Excelivnoice読み取り機能 #36

sonoh5n opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
🛠️ improvement Improve features which are working
Milestone

Comments

@sonoh5n
Copy link
Collaborator

sonoh5n commented Sep 11, 2024

内容

invoicefile.pyのExcelinvoice読み取り機能は、ExcelInvoiceFile.readread_excelinvoiceは重複しているので、read_excelinvoiceを削除する。

def read_excelinvoice(excelinvoice_filepath: RdeFsPath) -> tuple[pd.DataFrame, pd.DataFrame, pd.DataFrame]:
    ...

class ExcelInvoiceFile:
    ...
    def read(slef, ...):

注意

read_excelinvoiceは使用している箇所があるため注意。

@sonoh5n sonoh5n added the 🛠️ improvement Improve features which are working label Sep 11, 2024
@sonoh5n sonoh5n self-assigned this Sep 11, 2024
@sonoh5n sonoh5n added this to the Release Version1.0.2 milestone Sep 11, 2024
@sonoh5n sonoh5n removed this from the Release Version1.0.2 milestone Oct 22, 2024
@sonoh5n sonoh5n added this to the v1.2.0 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ improvement Improve features which are working
Projects
None yet
Development

No branches or pull requests

1 participant