Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24.x series not sending finished heartbeat to Sentry? #3419

Open
oesteban opened this issue Jan 2, 2025 · 4 comments
Open

24.x series not sending finished heartbeat to Sentry? #3419

oesteban opened this issue Jan 2, 2025 · 4 comments
Labels

Comments

@oesteban
Copy link
Member

oesteban commented Jan 2, 2025

What happened?

While we record started runs for the 24.x series, we are not collecting a single success ping. We may have accidentally discontinued that?

What command did you use?

n/a

What version of fMRIPrep are you running?

24.x

How are you running fMRIPrep?

Other

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

No response

Additional information / screenshots

No response

@oesteban oesteban added the bug label Jan 2, 2025
@effigies
Copy link
Member

effigies commented Jan 2, 2025

What about 23.2? There should have been very little change infrastructure change between 23.2 and 24.0.

@oesteban
Copy link
Member Author

oesteban commented Jan 2, 2025

We do see some records:

>>> versions_success.sum(axis=0)

20.2    158597.0
21.0    152072.0
22.0     85018.0
22.1     88046.0
23.0     89596.0
23.1    223020.0
23.2     94983.0
dtype: float64
>>> versions_started.sum(axis=0)

20.2     195312.0
21.0     169621.0
22.0      95871.0
22.1      98161.0
23.0     113328.0
23.1     352331.0
23.2     226747.0
24.0      69818.0
24.1      70409.0
older     35903.0
dtype: float64

That said, there seems to be a considerable performance drop for 23.2 (94983 successful / 226747 started)

@effigies
Copy link
Member

effigies commented Jan 2, 2025

Just comparing, I don't see a reason in our code that it should have changed:

23.1.4...24.1.1#diff-ece308de006691ca422e8aab537468cd6937ca6e683ce4d91918412b6912ce99R140-R147

Though we did bump major versions of sentry_sdk:

23.1.4...24.1.1#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552L288-R438

Could be a behavior change we didn't notice?

@oesteban
Copy link
Member Author

oesteban commented Jan 2, 2025

Another possibility is that the success heartbeat is misreporting the version string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants