Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reflections in unused (or not working) classes #1161

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Remove reflections in unused (or not working) classes #1161

merged 1 commit into from
Oct 11, 2023

Conversation

karakasa
Copy link
Contributor

These 4 classes use reflection codes but don't work due to various reasons (such as wrong porting from Java to NET).
Besides they are not used elsewhere in NPOI.

@karakasa karakasa mentioned this pull request Aug 12, 2023
Merged
@karakasa karakasa marked this pull request as ready for review August 12, 2023 06:11
@tonyqus tonyqus changed the base branch from master to aot August 13, 2023 14:20
@tonyqus tonyqus added this to the NPOI 2.7.1 milestone Aug 13, 2023
@tonyqus tonyqus added the aot label Aug 17, 2023
@tonyqus tonyqus merged commit d14a931 into nissl-lab:aot Oct 11, 2023
1 of 2 checks passed
@karakasa karakasa deleted the remove_reflection_not_working_cls branch October 12, 2023 03:34
@tonyqus tonyqus modified the milestones: NPOI 2.7.1, NPOI AOT May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
aot
Projects
None yet
Milestone
NPOI AOT
Development

Successfully merging this pull request may close these issues.
2 participants
@karakasa @tonyqus