Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save background custom colors as class and not hex inline style #89

Open
spencer-j opened this issue Feb 18, 2020 · 1 comment
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@spencer-j
Copy link

At the moment for example gutenberg custom background colors are saved as inline style with hex value of div .nk-awb-overlay Element.
Maybe its more consistent and better to do it corresponding with the gutenberg default blocks (Group, Cover, paragraph ...) do it – with classes "has-background has-colorname-background-color"
What do you think
Greets spencer

@nk-o
Copy link
Collaborator

nk-o commented Feb 26, 2020

Hi Spencer.

I thinking about this feature before, but I still don't know how to make it properly. Gutenberg uses 2 classes only - for text color and for background color.

In Ghost Kit used also Borders, Shadows. Also, we use Hover and Focus styles. We can't add just text or background color classes, we will need to generate other classes too.

I don't have a good solution for now.

Regards, nK.

@nk-o nk-o added enhancement New feature or request help wanted Extra attention is needed labels Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants