From bee64e6bf65d7bbe1b1c6635461de4757670e166 Mon Sep 17 00:00:00 2001 From: Mateusz Hawrus <48822818+nieomylnieja@users.noreply.github.com> Date: Thu, 15 Feb 2024 17:06:48 +0100 Subject: [PATCH] chore: Fix release workflow (#168) ## Motivation Turns out reusable workflow cannot be called from the step level but instead must be be called from job level. --- .github/workflows/release-candidate.yml | 2 ++ .github/workflows/release.yml | 14 ++++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release-candidate.yml b/.github/workflows/release-candidate.yml index 6e0986e4..08b11295 100644 --- a/.github/workflows/release-candidate.yml +++ b/.github/workflows/release-candidate.yml @@ -8,4 +8,6 @@ jobs: uses: ./.github/workflows/acc-tests.yml with: clientId: "${{ vars.TERRAFORM_NOBL9_CLIENT_ID }}" + project: "${{ vars.TERRAFORM_NOBL9_PROJECT }}" + secrets: clientSecret: "${{ secrets.TERRAFORM_NOBL9_CLIENT_SECRET }}" diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 60638897..3dc04688 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,8 +17,16 @@ on: - "v[0-9]+.[0-9]+.[0-9]+-beta" - "v[0-9]+.[0-9]+.[0-9]+-alpha" jobs: + test: + uses: ./.github/workflows/acc-tests.yml + with: + clientId: "${{ vars.TERRAFORM_NOBL9_CLIENT_ID }}" + project: "${{ vars.TERRAFORM_NOBL9_PROJECT }}" + secrets: + clientSecret: "${{ secrets.TERRAFORM_NOBL9_CLIENT_SECRET }}" goreleaser: runs-on: ubuntu-latest + needs: test steps: - name: Checkout uses: actions/checkout@v4.1.1 @@ -37,12 +45,6 @@ jobs: passphrase: ${{ secrets.PASSPHRASE }} - name: setup github run: git config --global url."https://n9-machine-user:${{ secrets.GH_TOKEN }}@github.com".insteadOf "https://github.com" - - name: Run acceptance tests - uses: ./.github/workflows/acc-tests.yml - with: - clientId: ${{ vars.TERRAFORM_NOBL9_CLIENT_ID }} - clientSecret: ${{ secrets.TERRAFORM_NOBL9_CLIENT_SECRET }} - project: ${{ vars.TERRAFORM_NOBL9_PROJECT }} - name: Run GoReleaser uses: goreleaser/goreleaser-action@v5.0.0 with: