Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKER] Onnx Op' Torch->Linalg Lowering #797

Open
vivekkhandelwal1 opened this issue Jul 29, 2024 · 2 comments
Open

[TRACKER] Onnx Op' Torch->Linalg Lowering #797

vivekkhandelwal1 opened this issue Jul 29, 2024 · 2 comments

Comments

@vivekkhandelwal1
Copy link
Contributor

vivekkhandelwal1 commented Jul 29, 2024

Below is the list of Onnx Ops for which Onnx->Torch lowering exists but they fail during Torch->Linag lowering phase. The aim is to prioritize these ops based on the models that are affected. If you're working on any of these ops then please create a tracker issue for the same and add your name to the owner.

Repro Instructions:
In order to reproduce the issue just take out the unit test for the concerned op from any of these files:

and run the below command:

torch-mlir-opt --convert-torch-onnx-to-torch --torch-decompose-complex-ops -torch-backend-to-linalg-on-tensors-backend-pipeline --split-input-file test.mlir

Note: The list might not be exhaustive so if you find any such Onnx op which fails during Torch->Linalg lowering then please do add this to the tracker.

Op Name Owner Models Affected Tracker Issue
CumSum @marbre #662, llvm/torch-mlir#2845
SplitToSequence
SequenceMap
CenterCropPad
RoiAlign
DeformConv
Optional
OptionalGetElement
NegativeLogLikelihoodLoss
Col2Im
MaxRoiPool
MaxUnpool
SequenceAt
SequenceErase
SequenceEmpty
SequenceInsert
SequenceConstruct
SequenceLength
@jinchen62
Copy link
Contributor

@vivekkhandelwal1 Is this for the same issue as #450? Both are for the ops that have onnx->torch support but fail on torch->linalg.

@vivekkhandelwal1
Copy link
Contributor Author

@vivekkhandelwal1 Is this for the same issue as #450? Both are for the ops that have onnx->torch support but fail on torch->linalg.

That was created way back for making the failing lit tests pass, the purpose was different. That issue now seems stale, I will close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants