Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check directory structure #29

Open
Rotzbua opened this issue Oct 9, 2024 · 3 comments
Open

feat: Check directory structure #29

Rotzbua opened this issue Oct 9, 2024 · 3 comments

Comments

@Rotzbua
Copy link

Rotzbua commented Oct 9, 2024

The recommended directory structure is:
https://nodered.org/docs/creating-nodes/packaging#directory-structure

Some projects do not follow this structure and put every node into the root directory.

@knolleary
Copy link
Member

@Rotzbua the docs describe the 'typical' directory structure. They also say:

There are no strict requirements over the directory structure used within the package.

So I believe it would be inappropriate to penalise a module for this.

@Rotzbua
Copy link
Author

Rotzbua commented Oct 10, 2024

Well the term "no strict requirements" means just, that the validator has not to fail if the directory structure does not match. There could be still a warning or information about the typical/recommended directory.

@knolleary
Copy link
Member

There are many different ways the node files could be organised. We should only warn if there is something that we consider 'bad' - but I'm not sure what that would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants