Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No host and schemes fields in swagger #78

Open
5 tasks done
kazuhitoyokoi opened this issue Apr 7, 2021 · 2 comments · May be fixed by #79
Open
5 tasks done

No host and schemes fields in swagger #78

kazuhitoyokoi opened this issue Apr 7, 2021 · 2 comments · May be fixed by #79

Comments

@kazuhitoyokoi
Copy link
Member

kazuhitoyokoi commented Apr 7, 2021

What are the steps to reproduce?

  1. Install node-red-node-swagger on Node-RED flow editor.
  2. Create REST API using http-in, template, http response nodes.
  3. Import the generated swagger definition on Swagger Editor using the URL, http://localhost:1880/http-api/swagger.json .
  4. Access the endpoint from the Swagger Editor.

What happens?

"404 Not Found" error occurred because the Swagger Editor access the own URL, https://editor.swagger.io/

1

What do you expect to happen?

The swagger definition contains host and schemes fields. And the Swagger Editor can access the endpoint on Node-RED.

2

Please tell us about your environment:

  • Node-RED version: 1.2.9
  • Node.js version: 10.20.1
  • npm version: 7.6.0
  • Platform/OS: macOS Big Sur 11.2.3
  • Browser: Google Chrome 89.0.4389.114 (Official Build) (x86_64)
@kazuhitoyokoi kazuhitoyokoi linked a pull request Apr 7, 2021 that will close this issue
6 tasks
@kazuhitoyokoi
Copy link
Member Author

@knolleary @dceejay Could you review this pull request when you have time?

@dceejay
Copy link
Member

dceejay commented Jul 12, 2021

HI - sorry - yes it looks good to me.
Happy to merge. @knolleary ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants