Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wish: docs for saml.getLogoutUrl and saml.getLogoutResponseUrl #312

Open
2 tasks
sibelius opened this issue Oct 8, 2018 · 1 comment
Open
2 tasks

wish: docs for saml.getLogoutUrl and saml.getLogoutResponseUrl #312

sibelius opened this issue Oct 8, 2018 · 1 comment

Comments

@sibelius
Copy link
Contributor

sibelius commented Oct 8, 2018

We have two methods to generate a logout request and a logout response:

  • saml.getLogoutUrl
  • saml.getLogoutResponseUrl

when should we use each of them?

I see that getLogoutResponseUrl uses an id of logoutUrl

is there any way to pass a callback logout url to logout request?

@markstos
Copy link
Contributor

You'll find both these methods are called from strategy.js. Do those examples answer your questions:

https://github.com/bergie/passport-saml/blob/master/lib/passport-saml/strategy.js#L49
https://github.com/bergie/passport-saml/blob/master/lib/passport-saml/strategy.js#L104

It would be helpful to have some JSdoc right in saml.js that explains right there how the functions are used.

@markstos markstos changed the title how to redirect after logout request url? wish: docs for saml.getLogoutUrl and saml.getLogoutResponseUrl Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants