Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply env variables to test timeouts consistently #407

Open
No9 opened this issue Aug 20, 2022 · 0 comments
Open

Apply env variables to test timeouts consistently #407

No9 opened this issue Aug 20, 2022 · 0 comments

Comments

@No9
Copy link
Member

No9 commented Aug 20, 2022

The test suite currently defines a session timeout for tests based on process.env.TEST_TIMEOUT
https://github.com/nodejs/llnode/blob/main/test/common.js#L173
This timeout has recently been incremented due to the restricted resources in GH Actions.

The timeout also isn't applied to all the tests and some have been overridden directly in the code base for longer tests.

t.timeoutAfter(30000);

A suggested approach is to have process.env.TEST_TIMEOUT and a new process.env.TEST_TIMEOUT_LONG consistently applied across the project so that the GH Actions can be incremented without modifying code and local development can shorten a test run by decreasing the same environment variables on the local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant