Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use debug_helper #414

Open
tony-go opened this issue Sep 22, 2022 · 0 comments
Open

refactor: use debug_helper #414

tony-go opened this issue Sep 22, 2022 · 0 comments

Comments

@tony-go
Copy link
Member

tony-go commented Sep 22, 2022

Context

As v8 API evolves and changes, we have to catch and handle breaking changes in the code.

@kvakil suggest to use debug_helper in llnode see proposal.

The debug module includes GetStackFrame and
GetObjectProperties functions. Presumably, V8 would be receptive to
patches to implement other functionality.

Scope

The main goal is to make llnode more maintainable in the mid/long term.

  • Reducing llnode's dependency with v8 API breaking changes
  • Documenting how to maintain debug_helper dependencies
  • Having a proper testing strategy

Risks/Questions

  • List what is missing in debug_helper that we need in llnode
  • Estimate the amount of work to do in debug_helper
  • How to include debug_helper into llnode (as a dependency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant