Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix flaky JSArrayBuffer test #421

Open
No9 opened this issue Sep 25, 2022 · 3 comments
Open

tests: Fix flaky JSArrayBuffer test #421

No9 opened this issue Sep 25, 2022 · 3 comments

Comments

@No9
Copy link
Member

No9 commented Sep 25, 2022

The JSArrayBuffer has failed in node 18 in lldb versions 8, 11, 13, 14 but when re-ran they all pass.
It's not clear what is causing it so we have it to optional in this PR
#419

Opening this to capture that it needs to be looked at and resolved if work is carried out in this area.

@tony-go
Copy link
Member

tony-go commented Sep 28, 2022

Maybe could we close this one? @No9

@No9
Copy link
Member Author

No9 commented Sep 28, 2022

Not sure why we want to close it @tony-go
I opened it to capture that we have set JSArrayBuffer to optional which isn't ideal and should be looked at.
That is still an issue I think unless there Is there something I've missed?

@tony-go
Copy link
Member

tony-go commented Sep 29, 2022

I opened it to capture that we have set JSArrayBuffer to optional which isn't ideal and should be looked at.

My bad 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants