make error when run without access to /proc

[jasonaowen]

• Node Version: node = v20.16.0, npm = 10.8.1
• Platform: Linux 6.8.0-40-generic x86_64
• Module: re2

Verbose output (from npm or node-gyp):

npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build', '--jobs', 0 ]
npm error make: the '-j' option requires a positive integer argument

When building a package using the systemd security option ProcSubset=pid, gyp sets the number of jobs to 0, which make does not accept.

I believe the relevant code is here:

node-gyp/lib/build.js

Lines 176 to 179 in e6f4ede

	} else if (jobs.toUpperCase() === 'MAX') {
	argv.push('--jobs')
	argv.push(require('os').cpus().length)
	}

The documentation for Node function os.cpus() says:

Returns an array of objects containing information about each logical CPU core. The array will be empty if no CPU information is available, such as if the /proc file system is unavailable.

This can be shown by getting the number of CPUs in a transient service unit:

$ node -e "console.log(require('node:os').cpus().length)"
16

$ sudo systemd-run -p ProcSubset=pid -t -- \
  node -e "console.log(require('node:os').cpus().length)"
0

In the event of os.cpus() not returning any information, I suggest that gyp should either default to some constant number of parallel jobs or let make run as many jobs as it wants.