From c1a5d208e8e9b327d42c804ec5b34cf4884edeaa Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Mon, 6 Jan 2025 23:47:00 +0000 Subject: [PATCH] fixup! src: drain platform tasks before creating startup snapshot --- src/node_snapshotable.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc index f3b0b8c172b49d..fe3fcc7184205f 100644 --- a/src/node_snapshotable.cc +++ b/src/node_snapshotable.cc @@ -992,10 +992,6 @@ ExitCode BuildSnapshotWithoutCodeCache( // example, a WeakRef may schedule an per-isolate platform task as a GC // root, and referencing an object in a context, causing an assertion in // the snapshot creator. - - // FIXME(joyeecheung): right now running the loop in the snapshot - // builder might introduce inconsistencies in JS land that need to - // be synchronized again after snapshot restoration. ExitCode exit_code = SpinEventLoopInternal(env).FromMaybe(ExitCode::kGenericUserError); if (exit_code != ExitCode::kNoFailure) {