Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document differences between Node.js fetch() implementations and the standard #52163

Open
mcollina opened this issue Mar 20, 2024 · 7 comments · May be fixed by #56314
Open

Document differences between Node.js fetch() implementations and the standard #52163

mcollina opened this issue Mar 20, 2024 · 7 comments · May be fixed by #56314
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@mcollina
Copy link
Member

We should add a section in our docs documenting how/why Node.js fetch() differs from the standard.

A few notable differences

  • new Response(asyncIterable) is an addition to standard
  • cookies handling
  • no forbidden headers

@KhafraDev definitely know more
@mcollina mcollina added the doc Issues and PRs related to the documentations. label Mar 20, 2024
@KhafraDev
Copy link
Member

Most of these are documented in undici's README, it should be pretty easy to copy the documentation from there. https://github.com/nodejs/undici?tab=readme-ov-file#undicifetchinput-init-promise

@AretiTsolakidou
Copy link

I totally agree, giving users the opportunity to know what Node.js fetch() is in both the documentation and in README will turn out to be very helpful.

@pi-nathan
Copy link

Yeah, at this point the only documentation on fetch just links to the MDN page which isn't even documentation for node fetch. I get that the APIs are supposed to be compatible, but it's not really useful documentation for anything other than basic API usage. At least linking to undici would be more accurate.

@mcollina
Copy link
Member Author

Would you like to send a PR?

@mcollina mcollina added the good first issue Issues that are suitable for first-time contributors. label Dec 13, 2024
@jacobra19
Copy link

Hi, is this being worked on? can i take it on myself? (looking to make my first contribution :-) )

@MoLow
Copy link
Member

MoLow commented Jan 1, 2025

@jacobra19 no activity for over 3 weeks, I am pretty sure you can go ahead and submit a PR

@KhafraDev
Copy link
Member

#56314 this is being worked on

@KhafraDev KhafraDev linked a pull request Jan 1, 2025 that will close this issue
doc: add differences between Node.js fetch and standard Fetch API #56314
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add differences between Node.js fetch and standard Fetch API asrar211/node
6 participants
@mcollina @MoLow @jacobra19 @KhafraDev @AretiTsolakidou @pi-nathan