Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: warning message still shows up even with disableExperimentalSEAWarning set to true #107

Open
YassinEldeeb opened this issue Aug 11, 2024 · 2 comments

Comments

@YassinEldeeb
Copy link

Hey,

So, I have this issue, where i see this warning message, which doesn't affect my application logic:

(node:8292) Warning: Currently the require() provided to the main script embedded into single-executable applications only supports loading built-in modules.
To load a module from disk after the single executable application is launched, use require("module").createRequire().
Support for bundled module loading or virtual file systems are under discussions in https://github.com/nodejs/single-executable

Looking at the test bellow, shows that the expected behavior is for this message to only be shown if the disableExperimentalSEAWarning flag is not set to true
https://github.com/nodejs/node/blob/66c807693e6a92ff6429d3890d3fb96ece99b623/test/fixtures/sea.js#L15

But, when looking at the source code, this doesn't seem to be the case, there's no checks for this flag to ignore showing the message if it's set or not.
https://github.com/nodejs/node/blob/66c807693e6a92ff6429d3890d3fb96ece99b623/lib/internal/main/embedding.js#L101

Please let me know if I'm missing something, and how to avoid logging this warning message? Thanks

@joyeecheung
Copy link
Member

joyeecheung commented Aug 16, 2024

This is a separate warning for require()-ing unsupported builtin modules (which means it may or may not work - we have never fully vetted that the builtin that you use works in SEA, your code might happen to work, or it may not, or it may seem to work but it crashes on some input - nobody has checked that module for the SEA use case, so nobody knows for sure).

@FiskPay
Copy link

FiskPay commented Nov 1, 2024

Any update on the matter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants