From 783ff006a8c3837c9ba968bd844d2a8dd93626fc Mon Sep 17 00:00:00 2001 From: uzlopak Date: Sat, 24 Aug 2024 23:46:32 +0200 Subject: [PATCH 1/4] ci: make autobahn workflow reusable workflow --- .github/workflows/autobahn.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/autobahn.yml b/.github/workflows/autobahn.yml index 6048bd5bdf4..f1c31bd6d98 100644 --- a/.github/workflows/autobahn.yml +++ b/.github/workflows/autobahn.yml @@ -1,13 +1,13 @@ name: Autobahn on: + workflow_call: workflow_dispatch: - pull_request: paths: - '.github/workflows/autobahn.yml' - 'lib/web/websocket/**' - 'test/autobahn/**' - + permissions: contents: read pull-requests: write From acb4bd9fb90735efcf7a90bc467a3d6c86699bcf Mon Sep 17 00:00:00 2001 From: Aras Abbasi Date: Sat, 24 Aug 2024 23:47:57 +0200 Subject: [PATCH 2/4] Apply suggestions from code review --- .github/workflows/autobahn.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/autobahn.yml b/.github/workflows/autobahn.yml index f1c31bd6d98..40c906abb5e 100644 --- a/.github/workflows/autobahn.yml +++ b/.github/workflows/autobahn.yml @@ -7,7 +7,6 @@ on: - '.github/workflows/autobahn.yml' - 'lib/web/websocket/**' - 'test/autobahn/**' - permissions: contents: read pull-requests: write From 46e5ad61edd576859ad67333d989dd1a73bc31db Mon Sep 17 00:00:00 2001 From: uzlopak Date: Sun, 25 Aug 2024 01:56:51 +0200 Subject: [PATCH 3/4] wroom wroom --- .github/workflows/triggered-autobahn.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/workflows/triggered-autobahn.yml diff --git a/.github/workflows/triggered-autobahn.yml b/.github/workflows/triggered-autobahn.yml new file mode 100644 index 00000000000..d8100bb61bf --- /dev/null +++ b/.github/workflows/triggered-autobahn.yml @@ -0,0 +1,16 @@ +name: Autobahn + +on: + pull_request: + types: + - labeled + +permissions: + contents: read + pull-requests: write + +jobs: + autobahn: + if: ${{ github.event.label.name == 'autobahn' }} + name: Autobahn Test Suite + uses: ./.github/workflows/autobahn.yml From 03e40cbc670afdbe4aaf4e0cfe26db2e407d9a53 Mon Sep 17 00:00:00 2001 From: uzlopak Date: Sun, 25 Aug 2024 01:57:02 +0200 Subject: [PATCH 4/4] wroom wroom --- .github/workflows/autobahn.yml | 11 ++++++++--- .github/workflows/nightly.yml | 8 ++++++++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.github/workflows/autobahn.yml b/.github/workflows/autobahn.yml index 40c906abb5e..df77a5f57f9 100644 --- a/.github/workflows/autobahn.yml +++ b/.github/workflows/autobahn.yml @@ -1,7 +1,12 @@ name: Autobahn + on: - workflow_call: workflow_dispatch: + workflow_call: + inputs: + node-version: + default: '22' + type: string pull_request: paths: - '.github/workflows/autobahn.yml' @@ -38,10 +43,10 @@ jobs: with: args: docker restart --time 0 --signal=SIGKILL fuzzingserver - - name: Setup Node + - name: Setup Node.js@${{ inputs.node-version || '22' }} uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 with: - node-version: 22 + node-version: ${{ inputs.node-version || '22' }} - name: Run Autobahn Test Suite run: npm run test:websocket:autobahn diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 307b1134ead..7da843a9e6e 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -17,6 +17,13 @@ jobs: runs-on: ubuntu-latest secrets: inherit + test-autobahn: + if: github.repository == 'nodejs/undici' + uses: ./.github/workflows/autobahn.yml + with: + node-version: 23-nightly + secrets: inherit + test-windows: if: github.repository == 'nodejs/undici' uses: ./.github/workflows/test.yml @@ -39,6 +46,7 @@ jobs: - test-linux - test-windows - test-macos + - test-autobahn runs-on: ubuntu-latest permissions: issues: write