Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addPanel() - check ID for uniqueness #29

Open
boldtrn opened this issue Jan 3, 2019 · 1 comment
Open

addPanel() - check ID for uniqueness #29

boldtrn opened this issue Jan 3, 2019 · 1 comment
Labels
enhancement

Comments

@boldtrn
Copy link

boldtrn commented Jan 3, 2019

Currently, when using the addPanel method using an already existing id, the panels get added on top of each other, which is not ideal. Maybe it would make sense to add an overwrite flag to the method or show a warning if the panel already exists?
@noerw
Copy link
Owner

noerw commented Jan 3, 2019

Good point. We could think of a mechanism to update a panel, but this should then be in a separate function updatePanel(id, update).
So addPanel() should throw an error for a duplicate ID.

@noerw noerw changed the title Add Panel - check id for uniquness addPanel() - check ID for uniqueness Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boldtrn @noerw